stripe-node icon indicating copy to clipboard operation
stripe-node copied to clipboard

Wrong description for balance transaction fees

Open Sytten opened this issue 3 years ago • 5 comments

Hi! The description of fee and fee_details is wrong. It is actually in cents not in % liked mentioned. See https://stripe.com/docs/api/balance_transactions/object#balance_transaction_object-fee https://github.com/stripe/stripe-node/blob/451533a273a417373b1cf320ee4d7e057c6dc3f6/types/2020-08-27/BalanceTransactions.d.ts#L49-L52 https://github.com/stripe/stripe-node/blob/451533a273a417373b1cf320ee4d7e057c6dc3f6/types/2020-08-27/BalanceTransactions.d.ts#L54-L57

Sytten avatar Sep 06 '21 20:09 Sytten

@Sytten Thanks for flagging. This is an issue with our codegen tooling that automatically creates the library and doesn't properly replace the %s for the string, we'll have to tweak it on our end so assigning to @richardm-stripe

remi-stripe avatar Sep 06 '21 21:09 remi-stripe

True also for Invoice.amount*: Screen Shot 2022-02-11 at 2 45 18 PM Screen Shot 2022-02-11 at 2 46 32 PM

xaphod avatar Feb 11 '22 19:02 xaphod

Thanks for the reports @Sytten and @xaphod - we're indeed not localizing these correctly across most SDKs (the %s should be the smallest currency unit). We should be able to fix this in the near future (labelling as a future change) but may require some non-trivial work as the SDKs are not currently localized.

dcr-stripe avatar Feb 12 '22 00:02 dcr-stripe

Thanks for the reports @Sytten and @xaphod - we're indeed not localizing these correctly across most SDKs (the %s should be the smallest currency unit). We should be able to fix this in the near future (labelling as a future change) but may require some non-trivial work as the SDKs are not currently localized.

Understood. The issue is that I interpreted %s as "percentages". If you can change it to anything non-tokenized it likely works. For example, "smallest currency unit" was great

xaphod avatar Feb 12 '22 01:02 xaphod

Issue with the same root cause: https://github.com/stripe/stripe-node/issues/1004

kamil-stripe avatar Apr 20 '22 19:04 kamil-stripe

Closing as a duplicate of https://github.com/stripe/stripe-node/issues/1004

pakrym-stripe avatar Jan 20 '23 17:01 pakrym-stripe