stripe-node
stripe-node copied to clipboard
Wrong description for balance transaction fees
Hi!
The description of fee
and fee_details
is wrong. It is actually in cents not in % liked mentioned. See https://stripe.com/docs/api/balance_transactions/object#balance_transaction_object-fee
https://github.com/stripe/stripe-node/blob/451533a273a417373b1cf320ee4d7e057c6dc3f6/types/2020-08-27/BalanceTransactions.d.ts#L49-L52
https://github.com/stripe/stripe-node/blob/451533a273a417373b1cf320ee4d7e057c6dc3f6/types/2020-08-27/BalanceTransactions.d.ts#L54-L57
@Sytten Thanks for flagging. This is an issue with our codegen tooling that automatically creates the library and doesn't properly replace the %s for the string, we'll have to tweak it on our end so assigning to @richardm-stripe
True also for Invoice.amount*
:
Thanks for the reports @Sytten and @xaphod - we're indeed not localizing these correctly across most SDKs (the %s should be the smallest currency unit). We should be able to fix this in the near future (labelling as a future change) but may require some non-trivial work as the SDKs are not currently localized.
Thanks for the reports @Sytten and @xaphod - we're indeed not localizing these correctly across most SDKs (the %s should be the smallest currency unit). We should be able to fix this in the near future (labelling as a future change) but may require some non-trivial work as the SDKs are not currently localized.
Understood. The issue is that I interpreted %s as "percentages". If you can change it to anything non-tokenized it likely works. For example, "smallest currency unit" was great
Issue with the same root cause: https://github.com/stripe/stripe-node/issues/1004
Closing as a duplicate of https://github.com/stripe/stripe-node/issues/1004