stripe-js icon indicating copy to clipboard operation
stripe-js copied to clipboard

[BUG]: No overload for confirmSetup with confirmation_token

Open reubenmoes opened this issue 2 years ago • 1 comments

What happened?

image

    const { error, setupIntent: confirmedSetupIntent } = await this.client.confirmSetup({
      clientSecret,
      confirmParams: {
        confirmation_token: confirmationToken.id,
        expand: ['payment_method']
      },
      redirect: 'if_required'
    });

From the docs, confirmation_token is a valid parameter, and when testing, it successfully confirms the payment method. It looks like the types are just missing the overload for this.

https://docs.stripe.com/js/setup_intents/confirm_setup#confirm_setup_intent-options-confirmParams-confirmation_token

Environment

VSCode

Reproduction

No response

reubenmoes avatar Apr 20 '24 00:04 reubenmoes

Hi @reubenmoes, thanks for your report. I have passed on this issue for investigation.

fruchtose-stripe avatar Apr 25 '24 18:04 fruchtose-stripe

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 19 '24 01:05 stale[bot]

Hi @reubenmoes, this has been addressed in #606, which is part of release v3.4.1.

fruchtose-stripe avatar May 20 '24 18:05 fruchtose-stripe

Closing since it looks like it's been resolved in #606! Please feel free to reopen if there's any further issues with this.

awalker-stripe avatar Jun 03 '24 20:06 awalker-stripe