stripe-java icon indicating copy to clipboard operation
stripe-java copied to clipboard

Please add "Automatic-Module-Name" manifest entry

Open ao-apps opened this issue 3 years ago • 2 comments

Please add "Automatic-Module-Name" manifest entry, defining a stable, future-proof module name. This will allow us on Java 9+ to use the API with confidence.

The module name will typically be the top-most package in the project, so I suggest "com.stripe".

Thank you,

  • Dan

ao-apps avatar Jun 11 '21 03:06 ao-apps

@aoindustries Thanks for the report, we'll have a look internally to see how to address this

remi-stripe avatar Jun 14 '21 02:06 remi-stripe

Or, better yet, provide a fully functional module-info.class.

Can place in root of JAR: https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html

Or, can use MRJAR and place in META-INF/versions/9: https://www.baeldung.com/maven-multi-release-jars

Please note, in our experience in Java 11, placing module-info.class in root of JAR allows for javadocs with Module sections. Placing in MRJAR generates javadocs that are not module-aware.

ao-apps avatar Jul 01 '21 10:07 ao-apps