stripe-identity-react-native icon indicating copy to clipboard operation
stripe-identity-react-native copied to clipboard

[Android] brand logo is missing on the top of the screen

Open nicolasdevienne opened this issue 2 years ago • 6 comments
trafficstars

Hi all! Brand logo is missing on the top left of the screen for Android. For iOS it works!

logo android

nicolasdevienne avatar Sep 22 '23 21:09 nicolasdevienne

hi @nicolasdevienne could you double check the asset is in .png format is loaded correctly? Here is how the logo is correctlyed loaded in the example app, you could verify that by executing yarn android under the example dir

ccen-stripe avatar Sep 27 '23 17:09 ccen-stripe

hi @nicolasdevienne could you double check the asset is in .png format is loaded correctly? Here is how the logo is correctlyed loaded in the example app, you could verify that by executing yarn android under the example dir

Thx @ccen-stripe! My image was in res/drawable folder for Android but I have just changed as you tell me and now it works!

nicolasdevienne avatar Sep 27 '23 19:09 nicolasdevienne

Hi @ccen-stripe, I have just discover that on Android simulator the image is present but missing on a real device...

nicolasdevienne avatar Nov 15 '23 16:11 nicolasdevienne

hey @nicolasdevienne could you retry with the example app here? I just built it on a real device pixel-5 and it seems working fine:

deviceRecording

ccen-stripe avatar Nov 22 '23 19:11 ccen-stripe

Hi @ccen-stripe as you can see on the following screens, on simulator it's OK but KO on real device. I don't understand. For iOS it's OK for the two ways : simulator and real device.

Screenshot_1702050544 Screenshot_20231208-170106

My code is very simple :

import brandLogo from '../../../../../assets/shared/images/medadom_icon.png';
...
await presentIdentityVerificationSheet({ sessionId, ephemeralKeySecret, brandLogo: Image.resolveAssetSource(brandLogo) });

Also I notice that the text are not in French language. Can you translate it in the next version please?

nicolasdevienne avatar Dec 08 '23 16:12 nicolasdevienne

hi @nicolasdevienne FR translation should be ready now, you don't need to upgrade the SDK version as it comes from our backend. Re. image not showing up, could you verify this issue is reproducible with your device from our example android app ? I tried with a couple of physical devices but cannot reproduce it.

ccen-stripe avatar Jan 08 '24 22:01 ccen-stripe

following up in https://github.com/stripe/stripe-identity-react-native/issues/156

ccen-stripe avatar May 21 '24 22:05 ccen-stripe