stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

Improve pane transitions in bank auth flow

Open tillh-stripe opened this issue 1 year ago • 3 comments

Summary

This pull request adds proper pane slide transitions in the bank auth flow, and a fade effect for the Stripe logo in the top bar.

We exclude the attach-payment screen from the slide transitions, as it would just cause a slide from one loading indicator to another (we use a fade instead).

Motivation

Testing

  • [ ] Added tests
  • [ ] Modified tests
  • [ ] Manually verified

Screen recordings

Before

https://github.com/stripe/stripe-android/assets/110940675/660fb0e7-742f-4a44-946a-9774c0d133d7

After

https://github.com/stripe/stripe-android/assets/110940675/fcd53593-3b8f-429f-92dc-295216985f0c

Changelog

tillh-stripe avatar Jun 25 '24 18:06 tillh-stripe

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ -1 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -1 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.5 KiB │ -6 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.4 KiB │ +6 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 55.1 KiB │ -1 B │ 127.3 KiB │  0 B │ (total)

github-actions[bot] avatar Jun 25 '24 18:06 github-actions[bot]

Looking good! I noticed in the 'after' that the bank logos load simultaneously, vs. the 'before' where a few logos loaded first and then the rest loaded afterward. Is that a change related to this PR? Or just happened to be the case during the recording?

malecks-stripe avatar Jun 28 '24 14:06 malecks-stripe

@malecks-stripe That’s likely because of caching from the previous run. We kick off the request for all bank logos at the same time, so any delays would be random.

tillh-stripe avatar Jul 02 '24 13:07 tillh-stripe