stripe-android
stripe-android copied to clipboard
stripe
[BUG] Wrong title "Front of identity card"
Summary
We only accept driving licences but in the interface users get confused because the headers are "Front of identity card" and "Back of identity card".
In German this translates to "Vorderseite des Personalausweises" which is not a driving license.
See also:
- https://github.com/stripe/stripe-ios/issues/3597
Version
The problem occurs with stripe-android v20.44.0
Details
We currently only accept driver's licences by defining options.document.allowed_types = ["driving_license"] when using the API
Available options are:
driving_license... Drivers license document type.id_card... ID card document type.passport... Passport document type.
The optimal solution would be that the title corresponds exactly with options.document.allowed_types. This is how the web version already does it.
Example:
options.document.allowed_types |
string used |
|---|---|
["driving_license"] |
<string name="stripe_front_of_dl">Front of driver\'s license</string> |
["id_card"] |
<string name="stripe_front_of_id">Front of identity card</string> |
["passport"] |
<string name="stripe_passport">Passport</string> |
["driving_license", "id_card", "passport"] |
<string name="stripe_front_of_id_document">Front of identity document</string> |
But in the interface the title is always "Front of identity card" (stripe_front_of_id)
The text is stripe_position_id_front: "Position your identity card in the centre of the frame".
In the code you only use stripe_front_of_id here.
The strings stripe_front_of_dl "Front of driving licence" and "Back of driving licence" (stripe_back_of_dl) are defined but not used in the code.
On the first screen you use: "Get ready to scan your photo ID" which is defined here.
@ccen-stripe In the web version it explicitly says "driver’s licencse" if that is the only document that’s accepted. It would be perfect if the SDK would also do it like this:
- Get ready to scan your driver's license Grab your driver's license
- Front of driver's license
- Flip your ID over Get ready to scan the back of your ID
- Back of driver's license
I've seen that with this commit in the PR
- https://github.com/stripe/stripe-android/pull/8671
these new translations were added:
<string name="stripe_front_of_id_document">Front of identity document</string>
<string name="stripe_back_of_id_document">Back of identity document</string>
but they are not used in the code yet.
Hi! Working on this now in https://github.com/stripe/stripe-android/pull/9829
Fixed in https://github.com/stripe/stripe-android/pull/9829
All references to "identity card" should now say "identity document" ✅
@kentwilliams-stripe Thank you very much!
The web version of the Stripe checkout page goes a step further. The title corresponds exactly with options.document.allowed_types.
Can you imagine doing it the same way? That would be greatly appreciated as it would make it perfectly clear for the users what they are required to do.
@googol7 Thanks for the suggestion, I've added it to our backlog! If this specific behavior is critical for your business use case, you can use a webview with verify.stripe.com instead of the mobile SDK.
@kentwilliams-stripe Thanks!
We use react-native-webview and there, verify.stripe.com is too slow when accessing the camera. It gets so slow that users can't scan their documents - especially on smartphones that are a bit older or whose CPUs aren't the fastest.