stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

Restrict DisplayOxxoDetails to library group scope

Open sfriedman-stripe opened this issue 1 year ago • 1 comments

Summary

Added library group scope to DisplayOxxoDetails

Motivation

DisplayOxxoDetails was inadvertently made public API, unlike the next action data for Konbini, Boleto, and now Multibanco. This was a bug, so we should properly restrict the scope and remove the public API.

Testing

  • [ ] Added tests
  • [ ] Modified tests
  • [x] Manually verified

Changelog

sfriedman-stripe avatar May 10 '24 05:05 sfriedman-stripe

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.9 MiB │   3.9 MiB │  0 B │   8.6 MiB │   8.6 MiB │  0 B 
     arsc │   2.2 MiB │   2.2 MiB │  0 B │   2.2 MiB │   2.2 MiB │  0 B 
 manifest │     5 KiB │     5 KiB │  0 B │  25.2 KiB │  25.2 KiB │  0 B 
      res │ 907.5 KiB │ 907.5 KiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │   2.9 MiB │   2.9 MiB │  0 B │   2.9 MiB │   2.9 MiB │  0 B 
    other │   194 KiB │   194 KiB │ -4 B │ 423.6 KiB │ 423.6 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.7 MiB │  12.7 MiB │ -4 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42998 │ 42998 │ 0 (+0 -0) 
   types │ 14761 │ 14761 │ 0 (+0 -0) 
 classes │ 12464 │ 12464 │ 0 (+0 -0) 
 methods │ 61047 │ 61047 │ 0 (+0 -0) 
  fields │ 40285 │ 40285 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6028 │ 6028 │  0
APK
    compressed    │   uncompressed   │                        
───────────┬──────┼───────────┬──────┤                        
 size      │ diff │ size      │ diff │ path                   
───────────┼──────┼───────────┼──────┼────────────────────────
  52.7 KiB │ -7 B │ 116.7 KiB │  0 B │ ∆ META-INF/CERT.SF     
  49.4 KiB │ +3 B │ 116.6 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
───────────┼──────┼───────────┼──────┼────────────────────────
 102.1 KiB │ -4 B │ 233.3 KiB │  0 B │ (total)

github-actions[bot] avatar May 10 '24 05:05 github-actions[bot]