stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

Update compose pay button to version 0.1.4

Open StefMa opened this issue 1 year ago • 11 comments

Summary

Just a small update of the compose pay button dependency.

Motivation

Background is that we are using stripe (so this library 😁 ) together with licensee. Unfortunately up to version 0.1.3 compose pay button didn't provide a valid <license> tag in their POM. This prevents us to update stripe as the transitive dependency compose pay button will report as "invalid license" (for us). This is now fixed, since compose pay button has the default Apache 2 license 🙂

See also the following related issue and PR: https://github.com/google-pay/compose-pay-button/issues/17 https://github.com/google-pay/compose-pay-button/pull/18

Seems this is the full changelog/diff of the update: https://github.com/google-pay/compose-pay-button/compare/fc3aacfd0bb632bdda40ba915f616a4a0cd0f87f..3418fd1ffd9dc9d9c88e368e721649f8ad0c62df

Testing

  • [ ] Added tests
  • [ ] Modified tests
  • [ ] Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

StefMa avatar Feb 27 '24 12:02 StefMa

@samer-stripe this is approved, but no checks are running... Could you please have a second look here? 🤔

StefMa avatar Mar 02 '24 09:03 StefMa

Hmm.. Seems the annotation is not available anymore 🤔. Maybe even a wrong one was used 🤷‍♂️

Might have a look later...

StefMa avatar Mar 04 '24 18:03 StefMa

@samer-stripe i fixed the annotation. Seems the wrong one was available (and used) in the classpath that got fixed in the new release 🤷

Now it should work 🙃 At least i can run ./gradlew assembleAndroidTest without issues...

StefMa avatar Mar 05 '24 07:03 StefMa

@samer-stripe whats the problem with the tests? 🤔 I don't get it...

StefMa avatar Mar 06 '24 07:03 StefMa

@samer-stripe ping 🤓

StefMa avatar Mar 12 '24 04:03 StefMa

@StefMa Bitrise and the other GitHub actions won't run on a branch from the remotely forked repo. Could you open a PR from a local fork of this repo?

samer-stripe avatar Mar 12 '24 19:03 samer-stripe

Sorry @samer-stripe but I understand what you mean.

What is a local fork? 🤔 Do you mean a git clone? 🤔 Actually I can't push a branch to this repo directly 😁

I already opened a PR a few month ago. See https://github.com/stripe/stripe-android/pull/7716

Even if that also included failing tests, it seems that @jaynewstrom-stripe somehow got the tests running on at least bitrise... 🤔

StefMa avatar Mar 12 '24 20:03 StefMa

@samer-stripe can we just merge it? 🙈 Or maybe cherry-picking the commits on your behalf and create a PR by yourself? 🤔

StefMa avatar Mar 21 '24 12:03 StefMa

Hey guys, this PR is a minor dependency bump. I provided all information you need to evaluate this on your own. This PR is open for a month already. Because of our internal security policy we are unable to merge any updates of the stripe-android sdk. I would really appreciate it if someone could have a look into this. Again, I'm also fine if someone of you create your own PR. I already suggested it here. Thank you 🙏

StefMa avatar Mar 28 '24 09:03 StefMa

I brought your change in and rebased it here: https://github.com/stripe/stripe-android/pull/8172/files and I also applied our dependency update script, which gives us a detailed view of what changed.

As is, this (transitively) updates compose to 1.6, which we're not quite ready to force all of our downstream consumers onto.

As a workaround, you can depend directly on compose pay button 1.0.0 in your application, which will transitively updated stripes dependency as well, unblocking you from updating in your application.

Thanks for the contribution, once we're ready to update to compose 1.6 and compose pay button 1.0.0, we will take this contribution so you will get attributed.

jaynewstrom-stripe avatar Mar 28 '24 15:03 jaynewstrom-stripe

Thanks for looking into it 🚀 Probably we will go with the workaround for now. Thanks!

StefMa avatar Apr 04 '24 07:04 StefMa