stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

Published 20 hours ago • verified publisher icon stripe

Use Compose `PrimaryButton` in `PaymentSheet`.

Open samer-stripe opened this issue 1 year ago • 1 comments

Summary

Use Compose PrimaryButton in PaymentSheet.

Motivation

Resolves MOBILESDK-1498

Testing

  • [ ] Added tests
  • [x] Modified tests
  • [x] Manually verified

samer-stripe avatar Feb 13 '24 19:02 samer-stripe

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │     2 MiB │     2 MiB │   +473 B │   4.2 MiB │   4.2 MiB │   +368 B 
     arsc │   1.5 MiB │   1.5 MiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
 manifest │   2.3 KiB │   2.3 KiB │      0 B │   8.1 KiB │   8.1 KiB │      0 B 
      res │ 363.2 KiB │ 363.2 KiB │      0 B │ 490.6 KiB │ 490.6 KiB │      0 B 
   native │   7.3 MiB │   7.3 MiB │      0 B │  18.4 MiB │  18.4 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ -1.2 KiB │   1.6 MiB │   1.6 MiB │ -1.2 KiB 
    other │ 116.1 KiB │ 116.1 KiB │     -8 B │ 273.1 KiB │ 273.1 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │   -731 B │  26.4 MiB │  26.4 MiB │   -828 B 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 21413 │ 21432 │ +19 (+123 -104)   
   types │  6640 │  6641 │  +1 (+104 -103)   
 classes │  5407 │  5408 │  +1 (+99 -98)     
 methods │ 31079 │ 31080 │  +1 (+2332 -2331) 
  fields │ 18097 │ 18098 │  +1 (+664 -663)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  262 │  262 │  0   
 entries │ 5514 │ 5514 │  0
APK 
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  4.8 KiB │ -1.2 KiB │   4.7 KiB │ -1.2 KiB │ ∆ assets/dexopt/baseline.prof  
    2 MiB │   +473 B │   4.2 MiB │   +368 B │ ∆ classes.dex                  
 52.2 KiB │     -9 B │ 119.9 KiB │      0 B │ ∆ META-INF/CERT.SF             
    790 B │     -6 B │     658 B │     -6 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │     +3 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
 32.1 KiB │     -2 B │ 119.8 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  2.1 MiB │   -731 B │   4.4 MiB │   -828 B │ (total)
DEX 
STRINGS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   21413 │ 21432 │ +19 (+123 -104) 
  
  + K3
  + L3
  + Lca/b;
  + Lca/c;
  + Lca/d;
  + Lca/e;
  + Lca/f;
  + Ld6/a;
  + Lea/c;
  + Lk8/d0;
  + Lp9/a;
  + Lp9/b;
  + Lp9/c;
  + Lp9/d;
  + Lp9/e;
  + Lp9/f;
  + Lp9/g;
  + Lp9/h;
  + Lp9/i;
  + Lp9/j;
  + Lp9/k;
  + Lp9/l;
  + Lr9/j;
  + Lt9/g;
  + Lt9/h;
  + Lt9/i;
  + Lt9/j;
  + Lt9/k;
  + Lt9/l;
  + Lt9/m;
  + Lt9/n;
  + Lt9/o;
  + Lt9/p;
  + Lv9/a0;
  + Lv9/a1;
  + Lv9/b0;
  + Lv9/b1;
  + Lv9/c0;
  + Lv9/c1;
  + Lv9/d0;
  + Lv9/d1;
  + Lv9/e0;
  + Lv9/e1;
  + Lv9/e;
  + Lv9/f0;
  + Lv9/f1;
  + Lv9/f;
  + Lv9/g0;
  + Lv9/g1;
  + Lv9/g;
  + Lv9/h0;
  + Lv9/h1;
  + Lv9/h;
  + Lv9/i0;
  + Lv9/i1;
  + Lv9/i;
  + Lv9/j0;
  + Lv9/j1;
  + Lv9/j;
  + Lv9/k0;
  + Lv9/k1;
  + Lv9/k;
  + Lv9/l0;
  + Lv9/l1;
  + Lv9/l;
  + Lv9/m0;
  + Lv9/m1;
  + Lv9/m;
  + Lv9/n0;
  + Lv9/n1;
  + Lv9/n;
  + Lv9/o0;
  + Lv9/o1;
  + Lv9/o;
  + Lv9/p0;
  + Lv9/p1;
  + Lv9/p;
  + Lv9/q0;
  + Lv9/q1;
  + Lv9/q;
  + Lv9/r0;
  + Lv9/r;
  + Lv9/s0;
  + Lv9/s;
  + Lv9/t0;
  + Lv9/t;
  + Lv9/u0;
  + Lv9/u;
  + Lv9/v0;
  + Lv9/v;
  + Lv9/w0;
  + Lv9/w;
  + Lv9/x0;
  + Lv9/x;
  + Lv9/y0;
  + Lv9/y;
  + Lv9/z0;
  + Lv9/z;
  + Lx9/g0;
  + Lx9/h0;
  + Lx9/i0;
  + M3
  + N3
  + O3
  + P3
  + Q3
  + R3
  + S3
  + T3
  + U3
  + V3
  + W3
  + X3
  + Y3
  + Z3
  + [Lc0/f;
  + [Ls9/b;
  + [Lt9/g;
  + [Lw9/r;
  + [Lx9/i0;
  + a4
  + b4
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:3d43588,r8-mode:full,version:8.2.47}
  
  - Lda/c;
  - Lda/d;
  - Lda/e;
  - Lda/f;
  - Lf6/a;
  - Lfa/a;
  - Lfa/b;
  - Lfa/c;
  - Lq9/j;
  - Lq9/k;
  - Lq9/l;
  - Ls9/g;
  - Ls9/h;
  - Ls9/i;
  - Ls9/j;
  - Lu9/e;
  - Lu9/f;
  - Lu9/g;
  - Lu9/h;
  - Lu9/i;
  - Lu9/j;
  - Lu9/k;
  - Lu9/l;
  - Lu9/m;
  - Lu9/n;
  - Lu9/o;
  - Lu9/p;
  - Lw9/a1;
  - Lw9/b1;
  - Lw9/c1;
  - Lw9/d1;
  - Lw9/e1;
  - Lw9/f1;
  - Lw9/g0;
  - Lw9/g1;
  - Lw9/h0;
  - Lw9/h1;
  - Lw9/i0;
  - Lw9/i1;
  - Lw9/j0;
  - Lw9/j1;
  - Lw9/k0;
  - Lw9/k1;
  - Lw9/l0;
  - Lw9/l1;
  - Lw9/m0;
  - Lw9/m1;
  - Lw9/n0;
  - Lw9/n1;
  - Lw9/o0;
  - Lw9/o1;
  - Lw9/p0;
  - Lw9/p1;
  - Lw9/q0;
  - Lw9/q1;
  - Lw9/r0;
  - Lw9/s0;
  - Lw9/t0;
  - Lw9/u0;
  - Lw9/v0;
  - Lw9/w0;
  - Lw9/x0;
  - Lw9/y0;
  - Lw9/z0;
  - Ly9/a0;
  - Ly9/b0;
  - Ly9/c0;
  - Ly9/c;
  - Ly9/d0;
  - Ly9/d;
  - Ly9/e0;
  - Ly9/e;
  - Ly9/f0;
  - Ly9/f;
  - Ly9/g0;
  - Ly9/g;
  - Ly9/h0;
  - Ly9/h;
  - Ly9/i0;
  - Ly9/i;
  - Ly9/j;
  - Ly9/k;
  - Ly9/l;
  - Ly9/m;
  - Ly9/n;
  - Ly9/o;
  - Ly9/p;
  - Ly9/q;
  - Ly9/r;
  - Ly9/s;
  - Ly9/t;
  - Ly9/u;
  - Ly9/v;
  - Ly9/w;
  - Ly9/x;
  - Ly9/y;
  - Ly9/z;
  - Lz9/b;
  - [Lcom/google/android/material/datepicker/d;
  - [Lt9/b;
  - [Lu9/g;
  - [Lx9/r;
  - [Ly9/i0;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:8652199,r8-mode:full,version:8.2.47}
  

TYPES:

   old  │ new  │ diff           
  ──────┼──────┼────────────────
   6640 │ 6641 │ +1 (+104 -103) 
  
  + Lca/b;
  + Lca/c;
  + Lca/d;
  + Lca/e;
  + Lca/f;
  + Ld6/a;
  + Lea/c;
  + Lk8/d0;
  + Lp9/a;
  + Lp9/b;
  + Lp9/c;
  + Lp9/d;
  + Lp9/e;
  + Lp9/f;
  + Lp9/g;
  + Lp9/h;
  + Lp9/i;
  + Lp9/j;
  + Lp9/k;
  + Lp9/l;
  + Lr9/j;
  + Lt9/g;
  + Lt9/h;
  + Lt9/i;
  + Lt9/j;
  + Lt9/k;
  + Lt9/l;
  + Lt9/m;
  + Lt9/n;
  + Lt9/o;
  + Lt9/p;
  + Lv9/a0;
  + Lv9/a1;
  + Lv9/b0;
  + Lv9/b1;
  + Lv9/c0;
  + Lv9/c1;
  + Lv9/d0;
  + Lv9/d1;
  + Lv9/e0;
  + Lv9/e1;
  + Lv9/e;
  + Lv9/f0;
  + Lv9/f1;
  + Lv9/f;
  + Lv9/g0;
  + Lv9/g1;
  + Lv9/g;
  + Lv9/h0;
  + Lv9/h1;
  + Lv9/h;
  + Lv9/i0;
  + Lv9/i1;
  + Lv9/i;
  + Lv9/j0;
  + Lv9/j1;
  + Lv9/j;
  + Lv9/k0;
  + Lv9/k1;
  + Lv9/k;
  + Lv9/l0;
  + Lv9/l1;
  + Lv9/l;
  + Lv9/m0;
  + Lv9/m1;
  + Lv9/m;
  + Lv9/n0;
  + Lv9/n1;
  + Lv9/n;
  + Lv9/o0;
  + Lv9/o1;
  + Lv9/o;
  + Lv9/p0;
  + Lv9/p1;
  + Lv9/p;
  + Lv9/q0;
  + Lv9/q1;
  + Lv9/q;
  + Lv9/r0;
  + Lv9/r;
  + Lv9/s0;
  + Lv9/s;
  + Lv9/t0;
  + Lv9/t;
  + Lv9/u0;
  + Lv9/u;
  + Lv9/v0;
  + Lv9/v;
  + Lv9/w0;
  + Lv9/w;
  + Lv9/x0;
  + Lv9/x;
  + Lv9/y0;
  + Lv9/y;
  + Lv9/z0;
  + Lv9/z;
  + Lx9/g0;
  + Lx9/h0;
  + Lx9/i0;
  + [Lc0/f;
  + [Ls9/b;
  + [Lt9/g;
  + [Lw9/r;
  + [Lx9/i0;
  
  - Lda/c;
  - Lda/d;
  - Lda/e;
  - Lda/f;
  - Lf6/a;
  - Lfa/a;
  - Lfa/b;
  - Lfa/c;
  - Lq9/j;
  - Lq9/k;
  - Lq9/l;
  - Ls9/g;
  - Ls9/h;
  - Ls9/i;
  - Ls9/j;
  - Lu9/e;
  - Lu9/f;
  - Lu9/g;
  - Lu9/h;
  - Lu9/i;
  
...✂

github-actions[bot] avatar Mar 15 '24 20:03 github-actions[bot]

Closing in favor of removing the PrimaryButtonNew due to Compose testing issues.

samer-stripe avatar May 26 '24 15:05 samer-stripe