stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

[BANKCON-5390] Adds back navigation on toolbar

Open carlosmuvi-stripe opened this issue 3 years ago • 1 comments

Summary

  • Shows back navigation on toolbar if a) backstack is not empty and b) screen does not block back navigation (via showBack flag).

https://user-images.githubusercontent.com/99293320/192070588-e5b1bca1-3ec1-4487-9d98-2befbfa938df.mp4

carlosmuvi-stripe avatar Sep 23 '22 23:09 carlosmuvi-stripe

Diffuse output:

OLD: financial-connections-example-release-base.apk (signature: none)
NEW: financial-connections-example-release-pr.apk (signature: none)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   6.5 MiB │   6.5 MiB │ +2.1 KiB │  18.3 MiB │  18.4 MiB │ +5.9 KiB 
     arsc │ 973.5 KiB │ 973.5 KiB │      0 B │ 973.4 KiB │ 973.4 KiB │      0 B 
 manifest │   2.2 KiB │   2.2 KiB │      0 B │   8.6 KiB │   8.6 KiB │      0 B 
      res │ 461.7 KiB │ 461.7 KiB │      0 B │ 650.7 KiB │ 650.7 KiB │      0 B 
    asset │   8.5 KiB │   8.5 KiB │     +6 B │   8.3 KiB │   8.3 KiB │     +6 B 
    other │  63.2 KiB │  63.2 KiB │      0 B │  64.1 KiB │  64.1 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │     8 MiB │     8 MiB │ +2.1 KiB │    20 MiB │    20 MiB │ +5.9 KiB 

         │          raw           │              unique              
         ├────────┬────────┬──────┼────────┬────────┬────────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff           
─────────┼────────┼────────┼──────┼────────┼────────┼────────────────
   files │      2 │      2 │    0 │        │        │                
 strings │ 117903 │ 117932 │  +29 │ 108851 │ 108876 │ +25 (+122 -97) 
   types │  17132 │  17141 │   +9 │  16062 │  16071 │  +9 (+10 -1)   
 classes │  14430 │  14439 │   +9 │  14430 │  14439 │  +9 (+10 -1)   
 methods │ 109341 │ 109377 │  +36 │ 106664 │ 106700 │ +36 (+62 -26)  
  fields │  64737 │  64750 │  +13 │  64510 │  64523 │ +13 (+26 -13)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  259 │  259 │  0   
 entries │ 4415 │ 4415 │  0
APK
     compressed     │    uncompressed    │                                
─────────┬──────────┼─────────┬──────────┤                                
 size    │ diff     │ size    │ diff     │ path                           
─────────┼──────────┼─────────┼──────────┼────────────────────────────────
 2.5 MiB │ +2.1 KiB │ 7.4 MiB │ +5.9 KiB │ ∆ classes2.dex                 
   8 KiB │     +8 B │ 7.9 KiB │     +8 B │ ∆ assets/dexopt/baseline.prof  
   576 B │     -2 B │   444 B │     -2 B │ ∆ assets/dexopt/baseline.profm 
─────────┼──────────┼─────────┼──────────┼────────────────────────────────
 2.5 MiB │ +2.1 KiB │ 7.4 MiB │ +5.9 KiB │ (total)
DEX
STRINGS:

   old    │ new    │ diff           
  ────────┼────────┼────────────────
   108851 │ 108876 │ +25 (+122 -97) 
  + 
  
  
  
  
  
  
  
  :02
  00¢20200H¢
  	0H¢
  ¨
  + 2
  
  
  
  
  
  
  
  
  
  
  
  
  
  €20:B100
  000¢J00HÆJ0HÆJ00HÆJ502002
  0200HÆJ020HÖJ	0HÖJ	0HÖR00¢
  	
  R08F¢
  R00¢
  
  R0¢
  ¨
  + _navigation
  + _showBack
  + _this_TopAppBar
  + (Lkotlin/jvm/functions/Function2;ZLkotlin/jvm/functions/Function0;Landroidx/compose/runtime/Composer;II)V
  + Back icon
  + Lcom/stripe/android/financialconnections/features/accountpicker/AccountPickerScreenKt_AccountPickerScreen_6;
  + Lcom/stripe/android/financialconnections/features/manualentrysuccess/ManualEntrySuccessScreenKt_ManualEntrySuccessScreen_4;
  + Lcom/stripe/android/financialconnections/ui/FinancialConnectionsSheetNativeActivity_NavHost_1_1;
  + Lcom/stripe/android/financialconnections/ui/FinancialConnectionsSheetNativeActivityKt_LocalNavHostController_1;
  + Lcom/stripe/android/financialconnections/ui/FinancialConnectionsSheetNativeActivityKt;
  + Lcom/stripe/android/financialconnections/ui/components/ComposableSingletons_TopAppBarKt_lambda-4_1;
  + Lcom/stripe/android/financialconnections/ui/components/ComposableSingletons_TopAppBarKt_lambda-5_1_1;
  + Lcom/stripe/android/financialconnections/ui/components/ComposableSingletons_TopAppBarKt_lambda-5_1;
  + Lcom/stripe/android/financialconnections/ui/components/TopAppBarKt_FinancialConnectionsTopAppBar_1_1;
  + Lcom/stripe/android/financialconnections/ui/components/TopAppBarKt_FinancialConnectionsTopAppBar_3;
  + LocalNavHostController
  + No NavHostController provided
  + SMAP
  AccountPickerScreen.kt
  Kotlin
  *S Kotlin
  *F
  + 1 AccountPickerScreen.kt
  com/stripe/android/financialconnections/features/accountpicker/AccountPickerScreenKt
  + 2 MavericksComposeExtensions.kt
  com/airbnb/mvrx/compose/MavericksComposeExtensionsKt
  + 3 CompositionLocal.kt
  androidx/compose/runtime/CompositionLocal
  + 4 Composables.kt
  androidx/compose/runtime/ComposablesKt
  + 5 Composer.kt
  androidx/compose/runtime/ComposerKt
  + 6 Dp.kt
  androidx/compose/ui/unit/DpKt
  + 7 Column.kt
  androidx/compose/foundation/layout/ColumnKt
  + 8 Layout.kt
  androidx/compose/ui/layout/LayoutKt
  + 9 fake.kt
  kotlin/jvm/internal/FakeKt
  + 10 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  + 11 Box.kt
  androidx/compose/foundation/layout/BoxKt
  + 12 Row.kt
  androidx/compose/foundation/layout/RowKt
  + 13 SnapshotState.kt
  androidx/compose/runtime/SnapshotStateKt__SnapshotStateKt
  *L
  1#1,443:1
  51#2:444
  52#2,15:446
  67#2,8:467
  77#2:478
  78#2,5:481
  76#3:445
  76#3:494
  76#3:567
  76#3:601
  76#3:636
  83#4,3:461
  50#4:479
  49#4:480
  460#4,13:506
  473#4,3:522
  25#4:527
  36#4:534
  36#4:544
  460#4,13:579
  460#4,13:613
  460#4,13:648
  473#4,3:662
  473#4,3:667
  473#4,3:672
  955#5,3:464
  958#5,3:475
  1057#5,6:528
  1057#5,3:535
  1060#5,3:540
  1057#5,6:545
  154#6:486
  154#6:521
  154#6:543
  154#6:551
  154#6:552
  154#6:553
  154#6:554
  154#6:555
  154#6:556
  154#6:557
  154#6:558
  154#6:559
  154#6:627
  74#7,6:487
  80#7:519
  84#7:526
  73#7,7:628
  80#7:661
  84#7:666
  75#8:493
  76#8,11:495
  89#8:525
  75#8:566
  76#8,11:568
  75#8:600
  76#8,11:602
  75#8:635
  76#8,11:637
  89#8:665
  89#8:670
  89#8:675
  1#9:520
  288#10,2:538
  67#11,6:560
  73#11:592
  77#11:676
  74#12,7:593
  81#12:626
  85#12:671
  76#13:677
  102#13,2:678
  *S KotlinDebug
  *F
  + 1 AccountPickerScreen.kt
  com/stripe/android/financialconnections/features/accountpicker/AccountPickerScreenKt
  *L
  72#1:444
  72#1:446,15
  72#1:467,8
  72#1:478
  72#1:481,5
  72#1:445
  148#1:494
  344#1:567
  358#1:601
  364#1:636
  72#1:461,3
  72#1:479
  72#1:480
  148#1:506,13
  148#1:522,3
  203#1:527
  204#1:534
  212#1:544
  344#1:579,13
  358#1:613,13
  364#1:648,13
  364#1:662,3
  358#1:667,3
  344#1:672,3
  72#1:464,3
  72#1:475,3
  203#1:528,6
  204#1:535,3
  204#1:540,3
  212#1:545,6
  151#1:486
  178#1:521
  209#1:543
  269#1:551
  270#1:552
  281#1:553
  282#1:554
  312#1:555
  313#1:556
  348#1:557
  353#1:558
  356#1:559
  363#1:627
  148#1:487,6
...✂

github-actions[bot] avatar Sep 23 '22 23:09 github-actions[bot]