stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

Inject LPM Repository

Open michelleb-stripe opened this issue 3 years ago • 1 comments

Summary

Motivation

Testing

  • [ ] Added tests
  • [ ] Modified tests
  • [ ] Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

michelleb-stripe avatar Aug 12 '22 17:08 michelleb-stripe

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │           uncompressed            
          ├──────────┬──────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old      │ new      │ diff     │ old       │ new       │ diff      
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼───────────
      dex │ 15.5 MiB │ 15.5 MiB │   -2 KiB │  52.2 MiB │  52.2 MiB │ -10.6 KiB 
     arsc │  1.8 MiB │  1.8 MiB │      0 B │   1.8 MiB │   1.8 MiB │       0 B 
 manifest │    4 KiB │    4 KiB │      0 B │  18.5 KiB │  18.5 KiB │       0 B 
      res │    1 MiB │    1 MiB │      0 B │   1.8 MiB │   1.8 MiB │       0 B 
   native │  2.5 MiB │  2.5 MiB │      0 B │   5.9 MiB │   5.9 MiB │       0 B 
    asset │    3 MiB │    3 MiB │   +457 B │     3 MiB │     3 MiB │    +457 B 
    other │ 81.7 KiB │ 81.7 KiB │      0 B │ 155.6 KiB │ 155.6 KiB │       0 B 
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼───────────
    total │ 23.9 MiB │ 23.9 MiB │ -1.6 KiB │  64.8 MiB │  64.8 MiB │ -10.2 KiB 

         │          raw           │              unique              
         ├────────┬────────┬──────┼────────┬────────┬────────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff           
─────────┼────────┼────────┼──────┼────────┼────────┼────────────────
   files │      4 │      4 │    0 │        │        │                
 strings │ 252193 │ 252155 │  -38 │ 215123 │ 215082 │ -41 (+44 -85)  
   types │  44487 │  44475 │  -12 │  40831 │  40817 │ -14 (+11 -25)  
 classes │  38027 │  38013 │  -14 │  38027 │  38013 │ -14 (+11 -25)  
 methods │ 222458 │ 222379 │  -79 │ 214431 │ 214350 │ -81 (+57 -138) 
  fields │ 163399 │ 163387 │  -12 │ 162344 │ 162331 │ -13 (+35 -48)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  334 │  334 │  0   
 entries │ 6238 │ 6238 │  0
APK
     compressed     │     uncompressed     │                               
─────────┬──────────┼──────────┬───────────┤                               
 size    │ diff     │ size     │ diff      │ path                          
─────────┼──────────┼──────────┼───────────┼───────────────────────────────
 2.3 MiB │ -1.7 KiB │    7 MiB │  -9.2 KiB │ ∆ classes3.dex                
 8.6 KiB │   +457 B │  8.5 KiB │    +457 B │ ∆ assets/dexopt/baseline.prof 
 3.2 MiB │   -315 B │  9.1 MiB │  -1.5 KiB │ ∆ classes4.dex                
─────────┼──────────┼──────────┼───────────┼───────────────────────────────
 5.5 MiB │ -1.6 KiB │ 16.2 MiB │ -10.2 KiB │ (total)
DEX
STRINGS:

   old    │ new    │ diff          
  ────────┼────────┼───────────────
   215123 │ 215082 │ -41 (+44 -85) 
  + ˜
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
   
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  20:EBS
  0j00	0
  000
  00¢J<0=2>0(0H¢?J@0_HJA0B02
  0jHJC0=20_H¢DR
  00X€¢
  R	0¢0X‚¢
  R
  00¢
  R
  000X€¢
   !R0_0#X€¢
  %&R'
  0(00#X‚¢
  R )
  0(00X€¢
  *R+
  0(0¢
  ,R0	0X€¢
  -R.
  0/00X‚¢
  R00_0X€¢
  1R2
  030X‚¢
  R40_0#8X¢
  567&R80_0X‚¢
  R9
  0(00X‚¢
  R0
  X‚¢
  R:0;0X‚¢
  ¨F
  +  repo: 
  + _uiContext
  + (Ljava/lang/String;Lcom/stripe/android/paymentsheet/paymentdatacollection/FormFragmentArguments;Lcom/stripe/android/ui/core/forms/resources/ResourceRepository;Lcom/stripe/android/ui/core/forms/resources/ResourceRepository;Lcom/stripe/android/paymentsheet/forms/TransformSpecToElement;Lkotlin/coroutines/CoroutineContext;Lkotlin/coroutines/CoroutineContext;)V
  + Got here 12: isLoaded: 
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_2_1_2;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_completeFormValues_lambda-18__inlined_combine_1_2;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_completeFormValues_lambda-18__inlined_combine_1_3;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_completeFormValues_lambda-18__inlined_combine_1;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_textFieldControllerIdsFlow_lambda-21__inlined_combine_1_2;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_textFieldControllerIdsFlow_lambda-21__inlined_combine_1_3;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_textFieldControllerIdsFlow_lambda-21__inlined_combine_1;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_userRequestedReuse_lambda-15__inlined_combine_1_2;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_userRequestedReuse_lambda-15__inlined_combine_1_3;
  + Lcom/stripe/android/paymentsheet/forms/FormViewModel_userRequestedReuse_lambda-15__inlined_combine_1;
  + Lcom/stripe/android/ui/core/forms/resources/LpmRepository_Factory;
  + SMAP
  Emitters.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Emitters.kt
  kotlinx/coroutines/flow/FlowKt__EmittersKt_unsafeTransform_1_1
  + 2 Transform.kt
  kotlinx/coroutines/flow/FlowKt__TransformKt
  + 3 FormViewModel.kt
  com/stripe/android/paymentsheet/forms/FormViewModel
  *L
  1#1,222:1
  48#2:223
  159#3,2:224
  *E
  
  + SMAP
  Emitters.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Emitters.kt
  kotlinx/coroutines/flow/FlowKt__EmittersKt_unsafeTransform_1_1
  + 2 Transform.kt
  kotlinx/coroutines/flow/FlowKt__TransformKt
  + 3 FormViewModel.kt
  com/stripe/android/paymentsheet/forms/FormViewModel
  *L
  1#1,222:1
  48#2:223
  165#3:224
  *E
  
  + SMAP
  Emitters.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Emitters.kt
  kotlinx/coroutines/flow/FlowKt__EmittersKt_unsafeTransform_1_1
  + 2 Transform.kt
  kotlinx/coroutines/flow/FlowKt__TransformKt
  + 3 FormViewModel.kt
  com/stripe/android/paymentsheet/forms/FormViewModel
  *L
  1#1,222:1
  48#2:223
  186#3:224
  *E
  
  + SMAP
  Emitters.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Emitters.kt
  kotlinx/coroutines/flow/FlowKt__EmittersKt_unsafeTransform_1_1
  + 2 Transform.kt
  kotlinx/coroutines/flow/FlowKt__TransformKt
  + 3 FormViewModel.kt
  com/stripe/android/paymentsheet/forms/FormViewModel
  *L
  1#1,222:1
  48#2:223
  206#3:224
  *E
  
  + SMAP
  Emitters.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Emitters.kt
  kotlinx/coroutines/flow/FlowKt__EmittersKt_unsafeTransform_1_1
  + 2 Transform.kt
  kotlinx/coroutines/flow/FlowKt__TransformKt
  + 3 FormViewModel.kt
  com/stripe/android/paymentsheet/forms/FormViewModel
  + 4 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  *L
  1#1,222:1
  48#2:223
  171#3:224
  170#3:225
  172#3:237
  173#3:244
  174#3:256
  800#4,11:226
  1360#4:238
  1446#4,5:239
  800#4,11:245
  *S KotlinDebug
  *F
  + 1 FormViewModel.kt
  com/stripe/android/paymentsheet/forms/FormVie
...✂

github-actions[bot] avatar Aug 29 '22 15:08 github-actions[bot]