stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

[Feature] Disabled button color not available in new Appearance API

Open vidicunt opened this issue 3 years ago • 4 comments

Hello!

The new appearance API is great! However I'd love it if it included an option for setting background and foreground colors when the primary button is inactivated.

Also borderStrokeWidthDp = null doesn't seem to be respected.

I'd also recommend giving us the option to select the typography text style using Compose and not a resId.

vidicunt avatar Jun 09 '22 12:06 vidicunt

@tommyzat Thanks for the request, our team will take a look

jameswoo-stripe avatar Jun 09 '22 17:06 jameswoo-stripe

Hey there,

So excited you're using our new API.

For the new colors, we'll take it into our backlog. I think it's a good idea we just had limited scope in the first iteration.

For the borderstroke width, setting it to be null will have it use Shapes.borderStrokeWidth value. This is the default value. I was able to see that it's working as intended via our example app's playground. Let me know if you need any help on the front.

For the compose colors, unfortunately we had to architect our API this way because our sheet uses both traditional XML views and compose. We're working on potentially using compose for the entire sheet but that is a ways away. If this is a dealbreaker for you, please file a separate issue so we can track the ask.

skyler-stripe avatar Jun 27 '22 23:06 skyler-stripe