stripe-android icon indicating copy to clipboard operation
stripe-android copied to clipboard

Published 20 hours ago • verified publisher icon stripe

Extendable StripeEditText subclasses

Open vlad-roid opened this issue 4 years ago • 3 comments

Summary

All StripeEditText subclasses made open instead of final.

Motivation

Allows extending all StripeEditTexts in order to customize them in places where styling won't help, and fix bugs in Material Components TextInputEditText/TextInputLayout. Specific use case for me: Override setBackground to apply rounded corners to collapsed label cutout.

Testing

Updated payments-core.api from public final StripeEditText subclasses to just public.

vlad-roid avatar Jul 31 '20 07:07 vlad-roid

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 31 '20 07:07 CLAassistant

@vlad-roid thanks for posting this PR. We'll need to investigate the implications of opening these classes before we can accept this PR.

mshafrir-stripe avatar Aug 10 '20 15:08 mshafrir-stripe

@mshafrir-stripe is there any update here? This kind of functionality is important for applications that want to implement their own UI.

davidtzhang avatar May 25 '21 08:05 davidtzhang