smokescreen
smokescreen copied to clipboard
stripe
report more detail on Dial errors
This PR teaches Smokescreen to report more detailed information about connection errors under a new metric cn.atpt.connect.err, tagged by type:<something>. It unconditionally reports this metric whenever cn.atpt.total is incremented with success:false because of a net.Error, i.e., when an outbound connection fails for network-y reasons.
This is the first of (at least) two PRs in this vein. A followup branch gives tests the ability to make assertions around metric emission. Then we'll add tests for connection failures and assert that the metrics added in this branch were correctly emitted.
It's fine to hold off on approving/merging this until the followup PRs have added tests for the new behavior.
Pull Request Test Coverage Report for Build 2827112941
- 10 of 20 (50.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.2%) to 63.559%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pkg/smokescreen/smokescreen.go | 10 | 20 | 50.0% |
| <!-- | Total: | 10 | 20 |
| Totals | |
|---|---|
| Change from base Build 2760383326: | -0.2% |
| Covered Lines: | 1043 |
| Relevant Lines: | 1641 |
