stringer
stringer copied to clipboard
Better error messages for feeds
Right now I've got a lot of failing feeds and I don't know why.
As the error reporting is pretty sparse (Error parsing
) it's hard to figure out what went wrong (on my side or a broken feed). Looking through each feed is burdensome.
If the error would be logged correctly it would be much easier (it does not really need to be shown in the web interface, if it can be found in heroku logs
I'm fine with it)
Logging is kinda, sorta half implemented already (but not "turned on"): https://github.com/swanson/stringer/blob/master/app/tasks/fetch_feed.rb
But it could use some love in getting it actually working and usable. I think just getting it reporting better errors to a logfile is a good first step.
Absolutely. I'm not even sure why these all seem to be failing. Two of them were working recently but the others are very infrequently updated. So, I'm not sure if they work at all or if they're failing because they're updated infrequently.
@unsymbol Your feeds are most-likely marked as failing due to issues introduced in several commits recently (although the content is fetched just fine). In bf50b9596c, feeds returning a 304 Not Modified header would be marked as failing. 4765c1a598 fixed that behavior, however introduced a new issue again causing the feeds to be marked as failing, which was fixed in 47e2e0d119.
Depening on which version you're on, either of these issues might have caused all the failing feeds.
So your feeds should turn green again once you're running the latest version and each feed gets updated (e.g. new stories in the feed) or (with #236 merged) when the feed gets fetched again.
Closing due to lack of interest. Interested parties may re-open if you want to continue the discussion of implementation.