strimzi-kafka-operator icon indicating copy to clipboard operation
strimzi-kafka-operator copied to clipboard

Handled `AnnotatedRouteNoHostException` causing the `KafkaRebalance` to get into `NotReady` state when CC is enabled form Disabled state

Open ShubhamRwt opened this issue 2 years ago • 6 comments

Signed-off-by: ShubhamRwt [email protected]

Type of change

  • Bugfix

Description

This PR fixes the issue for KafkaRebalance going into NotReady state when CC is enabled from Disabled state due to the AnnotatedRouteNoHostException

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • [ ] Write tests
  • [ ] Make sure all tests pass
  • [ ] Update documentation
  • [ ] Check RBAC rights for Kubernetes / OpenShift roles
  • [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • [ ] Reference relevant issue(s) and close them after merging
  • [ ] Update CHANGELOG.md
  • [ ] Supply screenshots for visual changes, such as Grafana dashboards

ShubhamRwt avatar Jun 02 '22 13:06 ShubhamRwt

/azp run regression

scholzj avatar Jun 05 '22 16:06 scholzj

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 05 '22 16:06 azure-pipelines[bot]

Added the tests @scholzj . I refactored the createKafkaRebalance method in KafkaRebalanceStateMachineTest class so that I can add Exception to the status and see the state change

ShubhamRwt avatar Jun 07 '22 11:06 ShubhamRwt

@ShubhamRwt Can you please fix the build and the DCO signoff?

scholzj avatar Jul 28 '22 08:07 scholzj

Sure @scholzj . Actually we need some discussion on this PR and yesterday Tom and I decided to have a meeting today regarding this

ShubhamRwt avatar Jul 28 '22 09:07 ShubhamRwt

I have made the new changes @ppatierno @tomncooper

ShubhamRwt avatar Aug 01 '22 08:08 ShubhamRwt

@tomncooper @ppatierno Does this PR need more changes?

ShubhamRwt avatar Sep 07 '22 07:09 ShubhamRwt

/azp run regression

scholzj avatar Sep 09 '22 09:09 scholzj

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 09 '22 09:09 azure-pipelines[bot]