strimzi-kafka-operator
strimzi-kafka-operator copied to clipboard
Move to OpenTelemetry
Looks like you have some failing tests:
[ERROR] io.strimzi.api.kafka.model.KafkaBridgeCrdIT.testLoadKafkaBridgeWithWrongTracingType
[ERROR] Run 1: KafkaBridgeCrdIT.testLoadKafkaBridgeWithWrongTracingType:95
Expected: (a string containing "Could not resolve type id 'wrongtype'" ignoring case and a string containing "known type ids = [jaeger]" ignoring case)
but: a string containing "known type ids = [jaeger]" ignoring case was "com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve type id 'wrongtype' as a subtype of `io.strimzi.api.kafka.model.tracing.Tracing`: known type ids = [jaeger, jaeger-otel] (for POJO property 'tracing')
at [Source: (URL); line: 9, column: 11] (through reference chain: io.strimzi.api.kafka.model.KafkaBridge["spec"]->io.strimzi.api.kafka.model.KafkaBridgeSpec["tracing"])"
[ERROR] Run 2: KafkaBridgeCrdIT.testLoadKafkaBridgeWithWrongTracingType:95
Expected: (a string containing "Could not resolve type id 'wrongtype'" ignoring case and a string containing "known type ids = [jaeger]" ignoring case)
but: a string containing "known type ids = [jaeger]" ignoring case was "com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve type id 'wrongtype' as a subtype of `io.strimzi.api.kafka.model.tracing.Tracing`: known type ids = [jaeger, jaeger-otel] (for POJO property 'tracing')
at [Source: (URL); line: 9, column: 11] (through reference chain: io.strimzi.api.kafka.model.KafkaBridge["spec"]->io.strimzi.api.kafka.model.KafkaBridgeSpec["tracing"])"
[ERROR] Run 3: KafkaBridgeCrdIT.testLoadKafkaBridgeWithWrongTracingType:95
Expected: (a string containing "Could not resolve type id 'wrongtype'" ignoring case and a string containing "known type ids = [jaeger]" ignoring case)
but: a string containing "known type ids = [jaeger]" ignoring case was "com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve type id 'wrongtype' as a subtype of `io.strimzi.api.kafka.model.tracing.Tracing`: known type ids = [jaeger, jaeger-otel] (for POJO property 'tracing')
at [Source: (URL); line: 9, column: 11] (through reference chain: io.strimzi.api.kafka.model.KafkaBridge["spec"]->io.strimzi.api.kafka.model.KafkaBridgeSpec["tracing"])"
Some nits. It would be also good to add this to CHANGELOG. Would be also good to have a short docs or a system test to better show how it should be configured and how it works. Could be a copy of the existing Jaeger ST.
@alesj @scholzj Is this section being updated? https://strimzi.io/docs/operators/in-development/using.html#assembly-distributed-tracing-str
Please also add PR number in changelog
Is this section being updated? https://strimzi.io/docs/operators/in-development/using.html#assembly-distributed-tracing-str
@PaulRMellor it should be ... once this PR is merged (but can of course be prepared / ready before)
or a system test to better show how it should be configured and how it works. Could be a copy of the existing Jaeger ST.
It's exactly how it's done. I extended the existing TracingST, to support both - OpenTracing and OpenTelemetry.
/azp run build