strimzi-kafka-oauth icon indicating copy to clipboard operation
strimzi-kafka-oauth copied to clipboard

OAuth librabry don't remove newline char at the end of secret

Open Frawless opened this issue 4 years ago • 2 comments

After a discussion with @mstruk we think the library should truncate \nat the end of secret. We hit this during refactor of Strimzi oauth tests.

For example: printf "%s" "team-a-client-secret" | base64 echo "team-a-client-secret" | base64

return different values because \n at the end of encoded data.

Frawless avatar Sep 01 '20 08:09 Frawless

This issue is still present and I hit it today. Is it possible to give it a priority?

michalxo avatar Mar 04 '21 12:03 michalxo

Unless there is a clear standard which says that whitespaces cannot be part of the secret I do not think we should remove them.

scholzj avatar Mar 04 '21 13:03 scholzj