stride icon indicating copy to clipboard operation
stride copied to clipboard

[Microthread] ctor async throwing

Open Eideren opened this issue 5 years ago • 0 comments

PR Details

A component whose ctor calls an async function crashes the editor, see #220. While the changes within this PR works, those changes might not be safe, I would like to hear from someone more familiar with the microthreading implementation if this is alright before setting this PR to ready, is that exception essential, does it occur outside of case #220 ? If it's not safe at all investigate what other methods I/we could investigate.

Related Issue

#220

Motivation and Context

Fix a bug, even if the context around this bug is questionable.

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Eideren avatar May 02 '20 12:05 Eideren