stride icon indicating copy to clipboard operation
stride copied to clipboard

[WIP] Add selection center rotation and scaling

Open nesrak1 opened this issue 6 years ago • 10 comments

PR Details

Adds rotation and scaling from the center or from the last selected object

Description

You can now scale from the center from a selection as well as transforming away from the center rather than from the origin of each object. The selection can also be rotated from the center rather than only the last selected object.

Related Issue

#488

Motivation and Context

Sometimes it makes more sense to scale from the center rather than the last selected object. For example, something that takes up multiple objects like a room would be hard to scale otherwise.

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

nesrak1 avatar Jul 24 '19 01:07 nesrak1

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 24 '19 01:07 CLAassistant

Edit: See below instead.

Eideren avatar Jul 25 '19 14:07 Eideren

I already had these fixes but forgot to commit, sorry!

nesrak1 avatar Jul 25 '19 18:07 nesrak1

Scaling negative works which may or may not be a good thing, since it seems to break lighting but can also flip the model.

nesrak1 avatar Jul 25 '19 19:07 nesrak1

It's quite alright :) Doesn't quite seem to work correctly if object don't have zeroed rotation / are inside parents

Eideren avatar Jul 26 '19 20:07 Eideren

@nesrak1 just checking, is the PR ready/finished?

xen2 avatar Aug 20 '19 12:08 xen2

Should be ready unless you find another bug I haven't seen yet

nesrak1 avatar Aug 20 '19 14:08 nesrak1

Ran a few tests and noticed some issues.

Here's what happens when I:

  • Create entity with some rotation (i.e. 90 degrees Y axis)
  • Put a sphere as children of this entity with some translation (i.e. Z = 2)

The gizmo is not at the expected location: image

Here is what's expected: image

xen2 avatar Aug 29 '19 12:08 xen2

@nesrak1 Hey, this PR hasn't been very active those past few months, are you still working on this or should we close this off ? If someone wants to take it from here please do so but leaving this active might prevent other people from tackling this issue.

Eideren avatar Jan 12 '20 11:01 Eideren

I plan to pick progress back up soon but I don't know when I will finish it.

nesrak1 avatar Jan 15 '20 06:01 nesrak1