chore: Improve launcher framework combobox (#2895)
PR Details
- The reason this line is barely visible is because it's the default setting when IsEnabled is set to false. The easiest way to fix this is to change the check condition from 1 to 0.
- I changed the version description from .NET Core XX to .NET XX. And because the issue says "It isn't .NET Core anymore, it should be just .NET 10 or .NET 8," I also deleted an if branch.
Related Issue
#2895
Types of changes
- [ ] Docs change / refactoring / dependency upgrade
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
- [ ] My change requires a change to the documentation.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] I have built and run the editor to try this change out.
@AIFSKATE please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"Contributor License Agreement
@dotnet-policy-service agree
Thanks @AIFSKATE , visually it looks definitelly better. I will let others to review your updates.
@VaclavElias was your intent to have the combo box be interactible when there is just one framework to choose from, or keep it non-interactible but slightly more visible than it currently is ? I think keeping it non-interactive is better as it conveys to the user that there is nothing for them to change there. Otherwise users might press on the combo box just to check if there is anything else they could set it to when that box doesn't have anything else but the default value.
I wanted only better visibility which is very good to promote .NET version. See the current state. If the combo box isn't needed that would be even better, but that would be better to solve in a separate issue. Which version even allowed to select multiple frameworks?
Which version even allowed to select multiple frameworks?
Pre net6.0 I think ? The launcher should support every engine version as long as feasible, so best leave that combo box in and have it slightly more opaque if possible.
I see, so the reason it wasn't visible was because there was only 1 item. What about, if there is only 1 item, it should be only a text?