stride icon indicating copy to clipboard operation
stride copied to clipboard

feat: Remove AssemblyProcessor unused option

Open Jklawreszuk opened this issue 1 year ago • 3 comments

PR Details

This PR removes unused parameter for AssemblyProcessor. Because of recent changes It is never used

  • [x] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have built and run the editor to try this change out.

Jklawreszuk avatar Oct 08 '24 18:10 Jklawreszuk

How does it determine it needs to generate a module initializer then? Another way to say it: how to we tell to not generate one?

Is it only based on the attribute? In that case, did we check that all previously generated initializer through the parameter do have that attribute?

Kryptos-FR avatar Oct 09 '24 07:10 Kryptos-FR

How does it determine it needs to generate a module initializer then? Another way to say it: how to we tell to not generate one?

Is it only based on the attribute? In that case, did we check that all previously generated initializer through the parameter do have that attribute?

if you dont want a module intializer generated then dont use stride.core.moduleinitializer generated shaders use system moduleinitializer now and all previous module initializers get generated through roslyn now in https://github.com/stride3d/stride/blob/master/sources/core/Stride.Core.CompilerServices/Generators/ModuleInitializerGenerator.cs

when is the scenario to not use an existing module initializer?

assemblyprocessor doesnt od anything anymore with the module initializers

IXLLEGACYIXL avatar Oct 09 '24 11:10 IXLLEGACYIXL

Tests failed in Teamcity: https://teamcity.stride3d.net/buildConfiguration/Engine_Tests_WindowsSimple/26996?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&expandPull+Request+Details=true&hideProblemsFromDependencies=false&expandBuildTestsSection=true&expandBuildProblemsSection=true

Eideren avatar Oct 20 '24 13:10 Eideren