stride icon indicating copy to clipboard operation
stride copied to clipboard
verified publisher icon stride3d

[Font] Update SharpFont library for additional fixes

Open Basewq opened this issue 1 year ago • 3 comments

PR Details

Successor to #2281 Must wait until pull at https://github.com/stride3d/SharpFont/pull/1 is merged and its nuget package has been updated to 1.0.1.

My understanding of Stride's build of SharpFont:

  • vonderborch's repo, aka SharpFont.NetStandard did not contain any major changes compared to Robmaister's repo- it mainly moved files around (no code changes) and the single code change involved loading/switching 32bit/64bit dll, which Stride already does (I think). So the above pull only merged and modified from the latest of Robmaister's repo.
  • Stride does not use freetype6 as provided in Robmaister's branch which is only on v2.6 - Stride uses v2.6.3 https://github.com/stride3d/freetype/tree/2.6.3 (and is named freetype), as per this https://github.com/stride3d/stride/blob/master/deps/freetype/checkout.bat

Related Issue

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have built and run the editor to try this change out.

Basewq avatar Jun 10 '24 00:06 Basewq

You're a god send, thanks a ton for taking over this one @Basewq and for looking into this further than I had :)

Eideren avatar Jun 10 '24 01:06 Eideren

All good, I should be thanking you! Spent hours trying to find solve a font display bug, then stumbled on your pull which helped finally figure out the issue. Really good timing, lol.

Also fixed the issue on the other repo, should be going to the right branch now.

Basewq avatar Jun 10 '24 12:06 Basewq

I'll look into publishing the package once teamcity is up

Eideren avatar Jun 10 '24 17:06 Eideren

Ready to merge. While there are some fixes within SharpFont, none appears to have impacted Stride at this time, so consider this more of a future proofing update.

Realistically, if there are font bugs that need fixing, consider updating the stride version of freetype repo: https://github.com/stride3d/freetype

Basewq avatar Jun 30 '24 23:06 Basewq

Thanks !

Eideren avatar Jul 01 '24 11:07 Eideren