stride icon indicating copy to clipboard operation
stride copied to clipboard

feat: Roslyn Diagnostics Analyzer for empty constructor

Open IXLLEGACYIXL opened this issue 2 years ago • 6 comments

PR Details

Adds a Warning for not having an Empty Constructor

Description

Diagnostics Analyzer for https://github.com/stride3d/stride/pull/2098 to throw at Compile Time a warning when an empty constructor is missing.

Types of changes

  • [x] Docs change / refactoring / dependency upgrade ( i have to make with vaso a new diagnostics website )
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] My change requires a change to the documentation.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed. ( 66 fail as same with master )
  • [x] I have built and run the editor to try this change out.

IXLLEGACYIXL avatar Jan 13 '24 20:01 IXLLEGACYIXL

Note: make sure to validate and merge #2105 first.

Kryptos-FR avatar Jan 15 '24 09:01 Kryptos-FR

for the tests, i freshly cloned stride and now im back to the standard 24 tests that fail normally, so i just had a corrupted clone

that is fine

IXLLEGACYIXL avatar Jan 15 '24 10:01 IXLLEGACYIXL

i will reopen when i know whats wrong with git lfs

IXLLEGACYIXL avatar Apr 23 '24 12:04 IXLLEGACYIXL

i think its ready to merge, should i change the name of the PR to use the new tags

IXLLEGACYIXL avatar Apr 28 '24 17:04 IXLLEGACYIXL

completed the changes

IXLLEGACYIXL avatar May 21 '24 21:05 IXLLEGACYIXL

the name of the PR should be changed to meet the tags for the new system that vaso made but i dont really know what it should be named to meet the categories

IXLLEGACYIXL avatar May 21 '24 21:05 IXLLEGACYIXL

Thanks !

Eideren avatar May 30 '24 08:05 Eideren

https://github.com/stride3d/stride-docs/pull/295 the docs PR for this analyzer

IXLLEGACYIXL avatar May 30 '24 12:05 IXLLEGACYIXL