stride
stride copied to clipboard
stride3d
Remove -77
PR Details
Changing -77 to 77
Description
XAML always spammed errors during usage continously that negative values are invalid
Motivation and Context
Nobody knows why its negative and there was no answer for it and the menuitems are the same as before, just not a spam of bind exceptions
Types of changes
- [ ] Docs change / refactoring / dependency upgrade
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
- [ ] My change requires a change to the documentation.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] I have built and run the editor to try this change out.
From what I see this code was trying to set MaxWidth to be ActualWidth - 77. Not sure what would trigger the MaxWidth to cause clipping the width value (maybe higher resolution screen?), but I don't think changing the value to positive would be correct. SumNum performs addition on two doubles. Maybe we need SubNum which will do subtraction?
Yeah it could have been a DPI issue (we had quite a lot of them in the past, but I think some were fixed in WPF in later versions). I'll try to find the original commit.
