stride icon indicating copy to clipboard operation
stride copied to clipboard

Fullscreen with Vulkan appears to be Broken

Open herocrab opened this issue 3 years ago • 3 comments

@Eideren: This issue has a bounty

Release Type: Official Release

Version: 4.0.1.1400

Platform(s): Windows

Describe the bug I am not able to go full screen using Vulkan. My project is setup using SDL context, but I tested with the default and found the same results. I am only making calls to Window:

        var window = Game.Window;
        _windowPosition = window.Position;
        window.IsBorderLess = true;
        window.Position = Int2.Zero;
        window.SetSize(resolution); // Breaks Vulkan

        // window.PreferredFullscreenSize = resolution;
        // window.IsFullscreen = true; // Breaks Vulkan

With both approaches the game window goes full screen size but the draw call ceases to run. There is no crash or exceptions thrown within my IDE.

To Reproduce Steps to reproduce the behavior:

  1. Create a new project.
  2. Add <StrideGraphicsApi>Vulkan</StrideGraphicsApi> to .csproj.
  3. Attempt any of the methods above.

Expected behavior I expect Vulkan to be able to go full screen.

I will create a repo of this and upload when I sit down to code again.

herocrab avatar Feb 19 '21 18:02 herocrab

I was able to reproduce this with a default project, targeting Vulkan and then setting Game.Window.Fullscreen to true. Unfortunately I can't upload the repo as it's larger than 10MB.

herocrab avatar Feb 19 '21 21:02 herocrab

I found this issue on Focus engine (Stride Fork):

https://github.com/phr00t/FocusEngine/issues/70#issuecomment-782376470

A workaround is to set the screen resolution and fullscreen flag in a configuration file and use it on launch. Apparently resizing Stride when using Vulkan is very complex.

herocrab avatar Feb 22 '21 15:02 herocrab

This issue has a $200,- bounty, if you are interested please follow the steps described here

Eideren avatar Mar 11 '22 21:03 Eideren

@stride3d Willing to give this a look if this hasn't been fixed.

tamamutu avatar Jul 07 '23 11:07 tamamutu

Sounds great and would be really appreciated. To work on an issue, create a branch and make a draft PR without code so everyone can see that you are working on it. Then start committing to that branch and convert to regular PR when you are ready for review. Thanks!

tebjan avatar Jul 07 '23 11:07 tebjan

Fixed in PR #1709

Eideren avatar Jul 10 '23 10:07 Eideren

Hi @tamamutu,

Would you be interested in more paid project work for Stride. We have Open collective projects available but if there are other ideas that you ware willing to contribute with, we are all ears. We can have a chat via Discord or another channel if you are up for it.

Aggror avatar Sep 25 '23 19:09 Aggror