testify proposal: assert.MapSubset (or just support maps in assert.Subset)

or perhaps expand subset so it can also handle maps.

given

a := map[string]string{
		"one": "foo",
		"two": "bar",
		"three": "baz",
	 }

b := map[string]string{
		"one": "foo",
		"three": "baz",
	 }

c := map[string]string{
		"one": "foo",
		"three": "notbaz",
	 }


assert.MapSubset(t, a, b, "a does not contain b") // will pass
assert.MapSubset(t, b, a, "b does not contain a") // will fail b does not have two=bar
assert.MapSubset(t, a, c, "a does not contain c") // will fail a does not have three=notbaz

Apr 01 '22 18:04 SleepyBrett

Enhancing Subset would definitely be better IMO.

One question, should this assert true?

a := map[string]string{
		"one": "foo",
		"two": "bar",
	 }

b := map[string]string{
		"one": "baz",
	 }

assert.Subset(t, a, b)

Does it test that the key and value are in the superset, or does it follow two value dereference (_, ok := a["one"]) which only checks the key? It would need to be documented.