vscode-spell-checker icon indicating copy to clipboard operation
vscode-spell-checker copied to clipboard

Spell Checking in commit section of vscode

Open titusfx opened this issue 6 years ago • 10 comments

It would be nice if the spell check is made in the commit section. comment section

titusfx avatar Jul 19 '17 14:07 titusfx

Is possible? How can we help you?

robsonpeixoto avatar Jul 20 '17 02:07 robsonpeixoto

@robsonpeixoto, it would be amazing if you can help! I think it is possible. Not 100% sure though. Nearly every pane in VS Code is an editor like window. The key thing to figure out is the URI to the window and convince the spell checker to check it. This is similar to issue #99, in that the URI is filtered out before it can be checked.

The spell checker filters out URIs that do not match a pattern here:

const schema = 'file';
const documentSelector =
    unique(languageIds
        .concat(enabledLanguageIds || [])
        .concat(LanguageIds.languageIds)
    )
    .map(language => ({ language, schema }))
    .concat([{ language: 'plaintext', schema: 'untitled' }]);

There is also another filter (the original) on the server side: here

const defaultExclude: Glob[] = [
    'debug:*',
    'debug:/**',        // Files that are generated while debugging (generally from a .map file)
    'vscode:/**',       // VS Code generated files (settings.json for example)
    'private:/**',
    'markdown:/**',     // The HTML generated by the markdown previewer
    'git-index:/**',    // Ignore files loaded for git indexing
    '**/*.rendered',
    '**/*.*.rendered',
    '__pycache__/**',   // ignore cache files.
];

Jason3S avatar Jul 20 '17 04:07 Jason3S

If anyone could look into this again, i would be very grateful :)

It really bothers me when i see my own commits with silly type-os.

KUGA2 avatar Nov 12 '19 14:11 KUGA2

I would be happy to look at this.

gbuktenica avatar Nov 13 '19 00:11 gbuktenica

There is another option: cspell CI/CD

Jason3S avatar Nov 15 '19 17:11 Jason3S

Any update on this? I frequently make spelling mistakes in my commit messages. The code is OK because already checked in the editor by this extension.

BillDenton avatar May 11 '20 11:05 BillDenton

I using a hack. I added a config to set the code as GIT_EDITOR and I'm creating the commit from the embedded terminal:

    "terminal.integrated.env.osx": {
        "EDITOR": "code --wait", // I'm using vscode as default editor inside the vscode terminal
        "GIT_EDITOR": "code --wait", // but you can use only for git
    },

robsonpeixoto avatar May 11 '20 11:05 robsonpeixoto

@robsonpeixoto I've added that in my global git config: .gitconfig [core] editor = code --wait That's fine for "git commit" from the command line within VS code, but for most of my commits, I use the VS Code built-in git message window.

Is there any useful information in: https://code.visualstudio.com/api/references/vscode-api#SourceControlInputBox

May be someone from VS Code team could help. Perhaps @sean-mcmanus

BillDenton avatar May 11 '20 11:05 BillDenton

I using a hack. I added a config to set the code as GIT_EDITOR and I'm creating the commit from the embedded terminal:

    "terminal.integrated.env.osx": {
        "EDITOR": "code --wait", // I'm using vscode as default editor inside the vscode terminal
        "GIT_EDITOR": "code --wait", // but you can use only for git
    },

it's amazing!!

FishingGo avatar Jun 15 '22 05:06 FishingGo

I think this problem is partially solved with this update of VS Code

Diogo-Rossi avatar Aug 07 '22 05:08 Diogo-Rossi

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Dec 12 '22 05:12 github-actions[bot]