cspell-dicts icon indicating copy to clipboard operation
cspell-dicts copied to clipboard

feat: move Australian animals names to en_shared

Open ccoVeille opened this issue 6 months ago • 2 comments

Add/Fix Dictionary

Dictionary: en_shared

Description

These animals are Australian, but the words are valid for all English dictionaries.

Most of these words were already in English dictionaries. They were added by @keith-oak with:

  • #4573

Please note, the following words were missing in English dictionaries:

  • bilby: only present as a noun
  • bilbies : missing
  • quokka: missing
  • quokkas: missing

References

  • Any source references.

Checklist

  • [X] By submitting this pull-request, you agree to follow our Code of Conduct
  • [X] Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

ccoVeille avatar Jun 25 '25 08:06 ccoVeille

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

autofix-ci[bot] avatar Jun 25 '25 08:06 autofix-ci[bot]

I'll have to transfer my branch out of my ccoVeille-fork organization, as it's no longer compatible with the new CI workflow.

And it's not a problem for me to do the change

EDIT: it's done, and it works

ccoVeille avatar Jun 25 '25 09:06 ccoVeille

Hi @Jason3S

Do you need anything from me on this PR?

ccoVeille avatar Jun 30 '25 11:06 ccoVeille

Hi @Jason3S

Do you need anything from me on this PR?

Please don't remove the words from the en_AU/src/additional_words.txt. No need to normalize the dictionaries. I would rather have the words in their origional location and add them to the shared word list. It helps to find the origins.

Jason3S avatar Jun 30 '25 20:06 Jason3S

Hi @Jason3S Do you need anything from me on this PR?

Please don't remove the words from the en_AU/src/additional_words.txt. No need to normalize the dictionaries. I would rather have the words in their origional location and add them to the shared word list. It helps to find the origins.

Done

ccoVeille avatar Jul 01 '25 05:07 ccoVeille

@ccoVeille,

Did you change your GitHub user?

Jason3S avatar Jul 01 '25 06:07 Jason3S

Hi @Jason3S Do you need anything from me on this PR?

Please don't remove the words from the en_AU/src/additional_words.txt. No need to normalize the dictionaries. I would rather have the words in their origional location and add them to the shared word list. It helps to find the origins.

Done

Thank you.

Jason3S avatar Jul 01 '25 06:07 Jason3S

@ccoVeille,

Did you change your GitHub user?

I don't know if you remember it, but I'm using an organization for my forks https://github.com/ccoveille-forks/

https://github.com/ccoveille-forks/cspell-dicts/

I did this to separate the projects I contribute randomly

This allows me to have 100+ projects on ccoveille-forks

While I only have 15+ on my own user: https://github.com/ccoVeille?tab=repositories&type=source

I have chosen to do this for clarity purpose.

But I discovered later that it comes with a limitation:

  • https://github.com/ccoVeille/github-forks-sanitizer/issues/3#issuecomment-2547466692

Which means I cannot use "Allow edits and access to secrets by maintainers"

This is the reason I sent you a request to join my fork as a member, which allowed you to change things on my PR even if it's an organization.

But lately you changed your CI workflow and introduced a bot autofix-ci

I had two choices:

  • fight to see how I could grant the bot in my fork owned by my ccoveille-forks
  • move out my fork from coveille-forks and put it back to ccoVeille

I chose simplicity.

ccoVeille avatar Jul 01 '25 07:07 ccoVeille

@ccoVeille, Did you change your GitHub user?

I don't know if you remember it, but I'm using an organization for my forks https://github.com/ccoveille-forks/

https://github.com/ccoveille-forks/cspell-dicts/

I did this to separate the projects I contribute randomly

This allows me to have 100+ projects on ccoveille-forks

While I only have 15+ on my own user: https://github.com/ccoVeille?tab=repositories&type=source

I have chosen to do this for clarity purpose.

But I discovered later that it comes with a limitation:

Which means I cannot use "Allow edits and access to secrets by maintainers"

This is the reason I sent you a request to join my fork as a member, which allowed you to change things on my PR even if it's an organization.

But lately you changed your CI workflow and introduced a bot autofix-ci

I had two choices:

  • fight to see how I could grant the bot in my fork owned by my ccoveille-forks
  • move out my fork from coveille-forks and put it back to ccoVeille

I chose simplicity.

Thank you for the clarity.

Jason3S avatar Jul 05 '25 06:07 Jason3S