cspell-dicts icon indicating copy to clipboard operation
cspell-dicts copied to clipboard

fix: add software-terms

Open ccoVeille opened this issue 7 months ago β€’ 10 comments

Add/Fix Dictionary

Dictionary: software-terms

Description

  • feat: add variations of marshal to software-terms.txt
  • feat: add encode/decode/unencode to software-terms
  • feat: add (un)package to software-terms
  • feat: add (un)wrap to software-terms
  • feat: add (un|de)serialize of software-terms
  • feat: add (un)review to software-terms
  • feat: add (un)revert to software-terms

References

  • Any source references.

Checklist

  • [X] By submitting this pull-request, you agree to follow our Code of Conduct
  • [X] Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

ccoVeille avatar May 08 '25 21:05 ccoVeille

πŸ€” It might be better to just add these to the appropriate English dictionary.

At the moment, the software terms dictionary is always included. Added mixed language terms impacts everyone.

Jason3S avatar May 09 '25 05:05 Jason3S

I thought about it this morning, yes.

Most will go to en_shared/additional.txt as they are missing in en_CA and en_AU

Some might go in en_shared/additional-ise.txt as they are specific to one English flavors.

ccoVeille avatar May 09 '25 06:05 ccoVeille

The main reason I added them to software terms initially is because some words are specific to software. You might use a language that is not English, but use these words anyway. But maybe I'm going too far.

Also, these some of the words I'm adding are simply variations of words that are already in software terms.

Do you think I should consider to clean up the software-terms file by moving them out of this file to move some of them to en_shared ?

ccoVeille avatar May 09 '25 07:05 ccoVeille

I was wondering why you not coming back to me 😱 😭, so I came here and saw my comments were still in pending stateπŸ€¦β€β™‚οΈ.

So here we go, I pressed send button πŸ˜œπŸ˜‚

Thank you for the comments. I'll try to answer them.

Jason3S avatar May 11 '25 06:05 Jason3S

The main reason I added them to software terms initially is because some words are specific to software. You might use a language that is not English, but use these words anyway. But maybe I'm going too far.

It is a balance. That logic is applied to the programming language dictionaries since most of their keywords are English words.

Also, these some of the words I'm adding are simply variations of words that are already in software terms.

Understood. There are many examples already in the list. I too debated on what to do with derivative words.

Do you think I should consider to clean up the software-terms file by moving them out of this file to move some of them to en_shared ?

Cleaning up software terms is an on-going project. Please remember, removing words tends to get people upset, especially if it breaks their CI/CD pipeline. For this reason, I have started splitting out the word lists, but not deleting terms.

Jason3S avatar May 11 '25 06:05 Jason3S

Do you think I should consider to clean up the software-terms file by moving them out of this file to move some of them to en_shared ?\n\nCleaning up software terms is an on-going project. Please remember, removing words tends to get people upset, especially if it breaks their CI/CD pipeline. For this reason, I have started splitting out the word lists, but not deleting terms.

I feel like we could add a legacy.txt to software-terms.txt what do you think?

ccoVeille avatar May 11 '25 18:05 ccoVeille

Because this PR can be used as a future reference, and because it's still unclear to me where each word I added should go, I plan to close this PR and open smaller ones, focusing on adding one word, and its variations

ccoVeille avatar May 11 '25 18:05 ccoVeille

Do you think I should consider to clean up the software-terms file by moving them out of this file to move some of them to en_shared ?\n\nCleaning up software terms is an on-going project. Please remember, removing words tends to get people upset, especially if it breaks their CI/CD pipeline. For this reason, I have started splitting out the word lists, but not deleting terms.

I feel like we could add a legacy.txt to software-terms.txt what do you think?

I think it is a good idea.

Jason3S avatar May 13 '25 07:05 Jason3S

Do you think I should consider to clean up the software-terms file by moving them out of this file to move some of them to en_shared ?\n\nCleaning up software terms is an on-going project. Please remember, removing words tends to get people upset, especially if it breaks their CI/CD pipeline. For this reason, I have started splitting out the word lists, but not deleting terms.

I feel like we could add a legacy.txt to software-terms.txt what do you think?

I think it is a good idea.

~~Opened https://github.com/streetsidesoftware/cspell-dicts/pull/4443~~

  • ~~https://github.com/streetsidesoftware/cspell-dicts/pull/4443~~

Replaced by #4453

  • #4453

ccoVeille avatar May 13 '25 20:05 ccoVeille

I still need to review this one.

ccoVeille avatar Jun 25 '25 14:06 ccoVeille