StreetComplete icon indicating copy to clipboard operation
StreetComplete copied to clipboard

New Quest: AddFerryAccessBicycle

Open mcliquid opened this issue 3 months ago • 14 comments

General

Affected tag(s) to be modified/added: bicycle Question asked: Does this ferry route transport bicycles?

Checklist

Checklist for quest suggestions (see guidelines):

  • [x] 🚧 To be added tag is established and has a useful purpose
  • [x] 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • [x] 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • [x] 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • [x] 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation

Element selection: ways, relations with route = ferry and !bicycle

Metadata needed:

Proposed UI:

  • Copy&Paste AddFerryAccessMotorVehicle quest and change motor_vehicle to bicycle
  • Icon: Change background color of the icon from yellow to purple

BTW: I'm surprised that this quest request doesn't exist yet. Have I overlooked something? FYI: I've added this quest already to my private fork and it works well.

mcliquid avatar Sep 19 '25 15:09 mcliquid

hi, this was discussed in the original issue for the pedestrian / car quests, with the conclusion that a bike quest might not be obvious to the surveyor: https://github.com/streetcomplete/StreetComplete/issues/39#issuecomment-456133038 I have proposed that this quest be added to SCEE instead: https://github.com/Helium314/SCEE/issues/821

paulklie avatar Sep 19 '25 18:09 paulklie

Though the longer I think about this, I believe this should be added to SC directly. Maybe we could add a third option which tags "bicycle:signed=no" when it is not clearly signed, similarly to moped access?

paulklie avatar Sep 22 '25 16:09 paulklie

In my experience from recent trips with ferry routes, it is usually clearly marked - mostly in the timetable. That's why I'd say the effort behind this quest is on the same level as the vegan/vegetarian quest for example. You also have to look at the menu first and can't answer the quest from the street when walking by. In the quest I tested (in my private fork), the quest pin was always displayed a few meters away from the ferry terminal in the water. In Hamburg, for example, it was ~50m in front of the terminal "Landungsbrücken", which means that I usually only see the quest when I am sitting on the ferry and traveling. And when I am on the ferry, I can already see whether bicycles are allowed or not. If I zoom out slightly, I can of course see the Quest from land and could quickly glance at the timetable information board to answer the Quest. Or I already know the answer because I live nearby or use the ferry regularly.

mcliquid avatar Sep 23 '25 08:09 mcliquid

Hey, I wanted to know if this quest is being worked on ?

I kinda want to focus on closing current issues than opening new ones so I'm looking on which one I can help on (since only one issue had the tag "help wanted").

Also don't hesitate to redirect me to other issues that could use help.

(Please note that even tho I'm experienced in coding, mainly in Java, I'm still discovering Kotlin with you guys so I would rather avoid stuff that is too hard/complex and focus on stuff that is accessible to Kotlin beginners.)

NariaReynhard avatar Sep 24 '25 08:09 NariaReynhard

Hey, I wanted to know if this quest is being worked on ?

Nevermind for that part I just read the last line I missed the first time. I'll check on other issues for now, but the rest of my message still stands

NariaReynhard avatar Sep 24 '25 08:09 NariaReynhard

I kinda want to focus on closing current issues than opening new ones so I'm looking on which one I can help on (since only one issue had the tag "help wanted").

I think you can defiantly work on this one, should be rather easy since its mostly just a copy of https://github.com/streetcomplete/StreetComplete/blob/master/app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/ferry/AddFerryAccessPedestrian.kt . If the decision is made not to include this quest in street complete, it is defiantly going to be included in SCEE (the "expert edition" of this app), since already approved there.

Also don't hesitate to redirect me to other issues that could use help.

https://github.com/streetcomplete/StreetComplete/issues/6502 might be such an idea.

paulklie avatar Sep 24 '25 10:09 paulklie

so I'm looking on which one I can help on (since only one issue had the tag "help wanted").

note that help is in general wanted, for one with "help wanted" it was just more help-dependent than others

matkoniecz avatar Sep 24 '25 11:09 matkoniecz

Also don't hesitate to redirect me to other issues that could use help.

I would say that in general not assigned ones ( https://github.com/streetcomplete/StreetComplete/issues?q=is%3Aissue%20state%3Aopen%20no%3Aassignee ) - unless one of few open PRs is opened for them or there was some very recent comment indicating an active work

though ones purely about interface for section where migration to multiplatform was not done yet are of a lower priority (as that work would need to be redone on migration)

matkoniecz avatar Sep 24 '25 11:09 matkoniecz

I wanted to know if this quest is being worked on ?

As I wrote initially, I've already implemented this quest in my local fork. It's certainly not pretty, but it works for me. Maybe that's an inspiration:

Main code: https://github.com/mcliquid/SCEE/commit/230c0e56d634033ea8e15968a3f42485e4d3a5b3 Custom icon: https://github.com/mcliquid/SCEE/commit/ff62ac12a11853e14b31547d071790d8d163759d

mcliquid avatar Sep 24 '25 14:09 mcliquid

As I wrote initially, I've already implemented this quest in my local fork. It's certainly not pretty, but it works for me. Maybe that's an inspiration:

Main code: mcliquid@230c0e5 Custom icon: mcliquid@ff62ac1

I believe this solution has a major issue: It does not incoperate the changes from https://github.com/streetcomplete/StreetComplete/issues/6373. Thus I think it would be easier to just copy the existing implementation for pedestrian/cars and use that as a base.

paulklie avatar Sep 24 '25 14:09 paulklie

Sure thing! I am still at the old SCEE status from June 6, 2025. At that time, the change had not yet been made and it has not yet been merged. As I wrote: Consider this purely as inspiration! 🙂

mcliquid avatar Sep 24 '25 14:09 mcliquid

I don't see a reason why this quest shouldn't be added to StreetComplete. PR welcome!

In the quest I tested (in my private fork), the quest pin was always displayed a few meters away from the ferry terminal in the water. In Hamburg, for example, it was ~50m in front of the terminal "Landungsbrücken", which means that I usually only see the quest when I am sitting on the ferry and traveling.

override val hasMarkersAtEnds = true

westnordost avatar Sep 30 '25 18:09 westnordost

@paulklie I'm pretty sure that you're technically superior to me when it comes to code - do you have time for the implementation? I'm happy to help with the icon. If you don't have time, I'll give it a try myself.

mcliquid avatar Oct 01 '25 12:10 mcliquid

@paulklie I'm pretty sure that you're technically superior to me when it comes to code -

Ehh, I hardly understand kotlin so I doubt that^

do you have time for the implementation? I'm happy to help with the icon. If you don't have time, I'll give it a try myself.

I was thinking maybe the student group around @NariaReynhard might be interested in this one, but sure go ahead!

paulklie avatar Oct 01 '25 13:10 paulklie