[WIP] Add Boat Rental Quest

[kmpoppe]

Resolves #5426.

Known issues - feedback required:

• Order in QuestModule
• Is this a RARE achievement (only 5.3k boat_rentals tagged today)
• Answer SVGs range from 0 to 100 in my view as to their fit (I love the floaty duckboat for "pedalboard" ;-)) Wouldn't CC0 images from wikicommons be the better idea? Lacking any kind of artistic skills, "fun icons", as asked for by westnordost in the comments of the Issue is nothing I can provide, any help would be appreciated!

[mnalis]

• I'd rather use rowboat_rental=yes/no instead of dinghy_rental=yes/no to avoid ambiguity (Dinghy may use motor instead of oars); especially as both tags (while documented) are not really used currently (single-digit uses worldwide).
• I think you meant (both in description and tag name) pedalboat instead of pedalboard (I was looking at https://en.wikipedia.org/wiki/Pedalboard in confusion just now :smiley: )
• I don't think it is RARE (but I might be affected by having dozens of boat rental places in few miles around me ATM). They are often not mapped though (esp. when they are seasonal only), and might use alternative tagging instead (e.g. shop=rental, rental=boat, shop=jetski, boat:rental=*, etc.)

[westnordost]

Hm, I am sad that you didn't take the pictures that I proposed. I see no reason whatsoever why one should prefer black-and-white icons over the more colorful icons. IMO the style of those also doesn't quite match. Some pictures show waves, some not, some have a more 3D look, others not.

[kmpoppe]

You listed 3 or 4 icons that could be used without any changes, for all others there's work needed that I am not capable of doing artistically to the standards I hold myself to.

This is why this is a draft PR.

[eginhard]

Catamarans would be another common boat type.

[westnordost]

Sounds like a hull type rather than a boat type? I mean, many/most pedal boats are catamarans in regards to the hull shape.

And this thing, whatever you'd call that (yes, it's bicycles on top)

is also a catamaran. (... well, I guess it is a very specific type of pedal boat... but unique enough that it should be tagged with another value)

But I guess the usual type of catamaran you get on boat rentals (that you would also call a catamaran) would be sailing boats, right? So, if this is common, maybe better have a value like sailing_catamaran.

[westnordost]

There's also an activity called "tubing" where you'd rent the tube of a truck tire. Not sure how common it is (compared to rafting/kayaking), I've only seen it in Vang Vieng (Laos):

https://duckduckgo.com/?q=vang+vieng+tubing&t=ffab&iax=images&ia=images

[kmpoppe]

Added help wanted, people being able to contribute good graphics are welcome to do so.

[westnordost]

I'll look into icons (maybe next week). Is it otherwise done? E.g. I think certain values should be considered ambiguous and thus if that value is present, the quest should be asked again (such as dinghy).

[kmpoppe]

I'll look through the comments when I get home and check how the answer could be made better!

[westnordost]

I added some icons on master. Most are from https://www.svgrepo.com/collection/water-sports-flat-icons/ or mashups from these.

Missing are:

• yacht - should be a smallish yacht with sails
• (raft - could be similar to SUP icon)

[westnordost]

So, summarizing the TODOs:

• add yacht
• add any of which I already added the icons
• treat dinghy_rental and some others (see taginfo) as ambiguous and hence as "need to ask this quest again"
• order rentals by commonness (rowboat should go up, many had been tagged with dinghy in the past)
• use new boat graphics
• use new quest icon (boat.svg)

[westnordost]

Are you still planning to work on this? It would be a shame if I prepared all those icons for nothing.