streetcomplete
New quest ref for emergency access points
- New Quest: "add ref" for
(highway = emergency_access_point or emergency = access_point) and !name and !ref and noref != yes and ref:signed != no and !~"ref:.*" - Added quest icon
- Add Option to Delete
- Add other Answer "Is Assembly Point"
- Remove highway-Tag if set
Fix #4384
In general: congratulations and thanks for submission! This quest is a bit borderline with relatively low usage but it fixes something validly reported as a problem by QA tool and requiring in-place survey and adding quest to more remote areas which are a bit quest-starved right now.
@Helium314 Unfortunately, I have to capitulate on the implementation of the image for the answer "Assembly Point". The Quest is from my point of view so far ready, but I just can't get the ImageView into the layout. I am not yet so deeply deved into Java. :( Would you be interested in taking over?
But then this PR wouldn't be yours anymore. I added a hint how to do it in the comment, maybe this will help you.
Thank you for all your help! I'm really thankful for that.
I've updated the PR according to your feedback and attached some screenshots of the functionallity. I would declare this PR as "ready for publish".
Screenshots: https://user-images.githubusercontent.com/3351668/192159389-8c25f36c-7a85-443e-82d7-cce155e27fb0.png https://user-images.githubusercontent.com/3351668/192159392-9a8e0b09-6a84-461e-8c7d-b78abb34fcf5.png https://user-images.githubusercontent.com/3351668/192159393-9865e7a1-a28e-435e-80e4-b90899b440a6.png
https://user-images.githubusercontent.com/3351668/192159392-9a8e0b09-6a84-461e-8c7d-b78abb34fcf5.png
"An emergency [...] is where people assemble in case of an emergency" sounds doppelt-gemoppelt. How about leaving out the first "emergency"? Would be more consistent with the other string, too.
Also, I am not sure if it is necessary to display the assembly point picture in such a huge size. On the other hand, I guess it can't hurt, I guess? (It looks like the size of the image makes the size of the dialog stretch out to its maximum dimensions)
Is it okay to give the graphic a width like "200p", or is that problematic for other resolutions?
The screenshot shows "highway milestone". Is that a bug?
No, it's tagged wrong / doubled. See https://www.openstreetmap.org/node/273208408