StreetComplete icon indicating copy to clipboard operation
StreetComplete copied to clipboard

handle surface vs tracktype conflicts

Open matkoniecz opened this issue 3 years ago • 5 comments

ask for confirmation in case where surface mismatches tracktype resurvey in cases where either surface or tracktype is definitely wrong fixes #662 #4063

if accepted in general, I will further refactor it to avoid specifying surface/tracktype relation twice, in two separate places

see also https://josm.openstreetmap.de/ticket/22102 - especially https://josm.openstreetmap.de/ticket/22102#comment:7 that would mirror code here and may have feedback about strength of checks

matkoniecz avatar Jun 13 '22 10:06 matkoniecz

@FloEdelmann I partially followed your suggestions in https://github.com/streetcomplete/StreetComplete/pull/4105/commits/5be361c8539c12564b404761b1eec67f3d95c29a

matkoniecz avatar Jun 13 '22 14:06 matkoniecz

draft per

if accepted in general, I will further refactor it to avoid specifying surface/tracktype relation twice, in two separate places

matkoniecz avatar Jun 13 '22 14:06 matkoniecz

I am now assuming that @westnordost is at least not disliking this idea.

matkoniecz avatar Jul 04 '22 20:07 matkoniecz

Yes, idea sounds fine. It is still draft though, which is why I did not look at the code.

westnordost avatar Jul 04 '22 21:07 westnordost

@matkoniecz very nice refactoring/simplification!

FloEdelmann avatar Jul 12 '22 18:07 FloEdelmann