StreetComplete icon indicating copy to clipboard operation
StreetComplete copied to clipboard

TimePicker width is cut off in landscape mode

Open lzmartinico opened this issue 6 years ago • 6 comments

When the app is in landscape mode, the time picker width is cut off, making it impossible to select a time (similarly to this Stackoverflow question) How to Reproduce Add steps to reproduce this behavior Turn your phone in Landscape mode, select an Opening Hours quest, Select some weekday, the watch is not displayed correctly in either opening or closing time tabs Versions affected Android 7.1.1, Street Complete 8.2 and previous

lzmartinico avatar Oct 19 '18 15:10 lzmartinico

This is an Android bug (imo). I already noticed this months ago and tried to workaround this, also consulting stackoverflow, but did not succeed.

So, it is a known problem but can not be fixed.

westnordost avatar Oct 20 '18 06:10 westnordost

Yes, it's an Android API bug, but it depends on how you use the TimePicker. The default AOSP calendar, for example, does not get cut off in landscape mode. I know they are not using a tabbed view, but maybe this could be useful? https://android.googlesource.com/platform/packages/apps/Calendar/+/master/src/com/android/calendar/event/EditEventView.java

lzmartinico avatar Oct 20 '18 08:10 lzmartinico

screenshot for reference: rps20181021_005119_990

HolgerJeromin avatar Oct 20 '18 22:10 HolgerJeromin

I checked if I could reproduce this on a Galaxy S6 running Android 7.0 and found a different but similar issue:

image

FWIW I ran into the same issue on Red Moon and decided not to fix it. The bug occurs in standard usage and is therefore an Android bug that should be fixed upstream, in my opinion.

If someone wanted to make a workaround, I think it would be better to write a TimePickerDialog library that works in landscape mode, rather than fixing it in each individual app.

smichel17 avatar Feb 21 '20 14:02 smichel17

add phrase to enable finding this issue: opening hours interface

matkoniecz avatar Jun 15 '22 03:06 matkoniecz

Would be fixed by #3796

westnordost avatar Jun 15 '22 11:06 westnordost

Well I now made that particular view scroll. Not great, but at least it is a mitigation.

westnordost avatar Dec 27 '22 15:12 westnordost