streamr-client-javascript icon indicating copy to clipboard operation
streamr-client-javascript copied to clipboard

use shared eslint-config-streamr-ts

Open harbu opened this issue 3 years ago • 0 comments

Use shared eslint-config-stream-ts in line with https://github.com/streamr-dev/network/pull/555. Had to add in a few additional rules to accommodate ongoing transition into TypeScript. Particularly rules:

  • @typescript-eslint/ban-ts-comment many instances of @ts-expect-error without description. Not worth adding in descriptions imo since they will be most likely replaced with types later on.
  • no-underscore-dangle again a lot of private fields leftover from javascript days, prolly worth changing when working on said code to prevent unexpected changes in behavior.
  • There were a few require statements left. They were tactically placed, so I assumed they are most likely there on purpose. Annotated such with the following // eslint-disable-next-line import/no-unresolved.

harbu avatar May 07 '21 14:05 harbu