pulsarctl icon indicating copy to clipboard operation
pulsarctl copied to clipboard

fix broken bash completion

Open lyra95 opened this issue 1 year ago • 2 comments

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #138.

Works in my local image

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

bash completion is broken

Modifications

Describe the modifications you've done.

use GenBashCompletionV2 instead of the old one

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • [ ] doc-required

    (If you need help on updating docs, create a doc issue)

  • [x] no-need-doc

    (Please explain why)

  • [ ] doc

    (If this PR contains doc changes)

lyra95 avatar Dec 31 '24 08:12 lyra95

@lyra95:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] avatar Dec 31 '24 08:12 github-actions[bot]

@lyra95:Thanks for providing doc info!

github-actions[bot] avatar Dec 31 '24 08:12 github-actions[bot]