pulsarctl icon indicating copy to clipboard operation
pulsarctl copied to clipboard

Add aarch64 as alias for arm64 architecture

Open veggerby opened this issue 1 year ago • 0 comments

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

When running in a dev-container on Mac Silicon, e.g. in a bookworm image,

Running uname -m on host yields arm64.

Simple devcontainer.json to reproduce:

{
    "name": "PulsarCTL",
    "image": "mcr.microsoft.com/devcontainers/base:bookworm"
}

Opening a terminal in the dev-container and running uname -m yields aarch64.

Running the install.sh script (via bash not sh and referencing v3.2.2.3 since current stable/default v3.1.0.2 has no release on arm64-linux):

version=v3.2.2.3 bash -c "$(curl -fsSL https://raw.githubusercontent.com/streamnative/pulsarctl/master/install.sh)"

Yields:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     42      0 --:--:-- --:--:-- --:--:--    42

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

This is due to script trying to download https://github.com/streamnative/pulsarctl/releases/download/v3.2.2.3/pulsarctl-aarch64-linux.tar.gz which should be https://github.com/streamnative/pulsarctl/releases/download/v3.2.2.3/pulsarctl-arm64-linux.tar.gz.

Modifications

Added aarch64 as alias for arm64 architecture in install.sh.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

This change required Apple Silicon processor to test, but regression is covered by existing tests.

Documentation

Check the box below.

Need to update docs?

  • [ ] doc-required

    (If you need help on updating docs, create a doc issue)

  • [x] no-need-doc

    A bug

  • [ ] doc

    (If this PR contains doc changes)

veggerby avatar Apr 29 '24 10:04 veggerby