pulsar-rs icon indicating copy to clipboard operation
pulsar-rs copied to clipboard

Published 20 hours ago • verified publisher icon streamnative

Fix/ack not sent

Open dghilardi opened this issue 2 years ago • 4 comments

Rewrite ConsumerEngine::<Exe>::engine method to better handle events and solve #175 bug.

Basically it introduces a supporting channel to merge message_rx and engine_rx channels.

dghilardi avatar Oct 08 '22 16:10 dghilardi

Hey @dghilardi :wave:, thank you for your contribution. Could you rebase your work on the branch master?

FlorentinDUBOIS avatar Oct 11 '22 13:10 FlorentinDUBOIS

Besides, during a rebase to test the source code, I saw this incoming changes in the update_topics which implies to not update anything, if a regex is not set. To me this change should not occurs https://github.com/streamnative/pulsar-rs/blob/f0a99fde280ab794d10c6206eb61a0c5e2514754/src/consumer.rs#L1945

FlorentinDUBOIS avatar Oct 11 '22 13:10 FlorentinDUBOIS

Hi @FlorentinDUBOIS sorry I didn't see your last message yesterday. By the way the change you're referring was not wanted, probably was a wrong merge or rebase. Now I've rebased my branch and looking at the diff is not present anymore. Please let me know if you need anything else.

dghilardi avatar Oct 12 '22 11:10 dghilardi

I noticed a possible regression in my code and fixed it

dghilardi avatar Oct 14 '22 10:10 dghilardi

retch the same problem here, hope to make a new release.

yswtrue avatar Oct 17 '22 17:10 yswtrue