pulsar-flink icon indicating copy to clipboard operation
pulsar-flink copied to clipboard

Connector support pulsar cluster with both JWT and TLS auth

Open asagjj opened this issue 2 years ago • 5 comments

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Motivation

when pulsar cluster start up with JWT auth and TLS for transport encryption. Connector cannot configure both authentication methods at the same time。

Modifications

I have provided a simple patch to fix this, add a config 'tls-trustcert-filepath' like 'auth-plugin'.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

related config key as below:

Catalog : catalog-tls-trustcerts-filepath DDL: properties.tls-trustcerts-filepath

Check the box below.

Need to update docs?

  • [x] doc-required https://github.com/streamnative/pulsar-flink/issues/544

asagjj avatar Apr 20 '22 12:04 asagjj

@asagjj:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] avatar Apr 20 '22 12:04 github-actions[bot]

@asagjj:Thanks for providing doc info!

github-actions[bot] avatar Apr 20 '22 12:04 github-actions[bot]

@asagjj Thanks for your contribution. Could you fix some failed workflow check.

nlu90 avatar Apr 20 '22 17:04 nlu90

@asagjj Thanks for your contribution. Could you fix some failed workflow check.

@nlu90 @syhily Would you please spare time to take a review?

asagjj avatar Apr 22 '22 00:04 asagjj

@syhily Hi,please take a review.

asagjj avatar May 17 '22 08:05 asagjj