oxia icon indicating copy to clipboard operation
oxia copied to clipboard

【Feature】add crc to wal

Open lsytj0413 opened this issue 1 year ago • 5 comments

oxia use wal to storage the LogEntry in segment files, should we add crc to each record to protect data corrupted?

lsytj0413 avatar Dec 12 '23 04:12 lsytj0413

Yes, one idea was to use a crc based on the past entries of the log as well. (eg: similar to git history). That would help in identifying any issues in non-common histories of the wal across nodes.

merlimat avatar Dec 15 '23 06:12 merlimat

/assign

lsytj0413 avatar Dec 15 '23 09:12 lsytj0413

@lsytj0413 Perhaps we can start with a proposal and design doc for how to implement the change. We can use discussions. eg: https://github.com/streamnative/oxia/discussions/new?category=proposal

merlimat avatar Dec 15 '23 17:12 merlimat

@lsytj0413 Perhaps we can start with a proposal and design doc for how to implement the change. We can use discussions. eg: https://github.com/streamnative/oxia/discussions/new?category=proposal

Yes, i will open an proposal to describe the detail design first.

lsytj0413 avatar Dec 16 '23 11:12 lsytj0413

@lsytj0413 Perhaps we can start with a proposal and design doc for how to implement the change. We can use discussions. eg: https://github.com/streamnative/oxia/discussions/new?category=proposal

Propocal at https://github.com/streamnative/oxia/discussions/412 ,PTAL

lsytj0413 avatar Dec 27 '23 08:12 lsytj0413

Seems this have been implemented at https://github.com/streamnative/oxia/pull/538#event-14438514703 @merlimat this can be close?

lsytj0413 avatar Sep 28 '24 05:09 lsytj0413