function-mesh icon indicating copy to clipboard operation
function-mesh copied to clipboard

adopt openshift olm annotation

Open freeznet opened this issue 3 years ago • 2 comments

Master Issue: https://github.com/streamnative/function-mesh/issues/486

Motivation

Fix failure in https://github.com/redhat-openshift-ecosystem/certified-operators/pull/1421

https://docs.openshift.com/container-platform/4.8/operators/operator_sdk/osdk-working-bundle-images.html#osdk-control-compat_osdk-working-bundle-images%22 add olm.properties to OLM annotation when build the openshift bundles

Modifications

Describe the modifications you've done.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • [ ] doc-required

    (If you need help on updating docs, create a doc issue)

  • [x] no-need-doc

    (Please explain why)

  • [ ] doc

    (If this PR contains doc changes)

freeznet avatar Oct 21 '22 09:10 freeznet

@freeznet:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] avatar Oct 21 '22 09:10 github-actions[bot]

@freeznet:Thanks for providing doc info!

github-actions[bot] avatar Oct 21 '22 09:10 github-actions[bot]