function-mesh icon indicating copy to clipboard operation
function-mesh copied to clipboard

[Waiting]Add oauth2 fields

Open jiangpengcheng opened this issue 2 years ago • 1 comments

Master Issue: #400

Motivation

pulsarctl requires some oauth2 parameters, such as audience, issuerUrl and so on, so we need to provide them explicitly.

the reason why I split this pr from #411 is that pulsarctl requires this oauth2Config and if #411 is released as FMv0.6.0 directly, and function-mesh-worker-service then bump the function-mesh to v0.6.0, since it doesn't provide an oauth2Config to the function-mesh, there will be a problem, so the correct order should be:

  1. include this PR in v0.5.0(or v0.6.0)
  2. bump function-mesh to v0.5.0(or v0.6.0) in the function-mesh-worker-service
  3. add a pr in function-mesh-worker-service to add the oauth2Config fields when neededgg
  4. include #411 in release v0.6.0(or v0.7.0)
  5. bump function-mesh to v0.6.0(or v0.7.0) in the function-mesh-worker-service

Modifications

Add an oauth2Config fields under the pulsar section

Verifying this change

  • [x] Make sure that the change passes the CI checks.

  • [x] This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • [x] no-need-doc

    will update the doc in next pr: #411

jiangpengcheng avatar Aug 15 '22 02:08 jiangpengcheng

Waiting for oauth2 implementation is fixed in the function-mesh-worker-service

jiangpengcheng avatar Aug 18 '22 02:08 jiangpengcheng