charts icon indicating copy to clipboard operation
charts copied to clipboard

feat(sn-platform): Add labels and missing missing configs for Vault

Open ericsyh opened this issue 3 years ago • 2 comments

Motivation

This PR made some enhancements to the Vault template

Modifications

This PR changed Vault template including:

  • Added labels config
  • Added the missing config of pod level containerSecurityContext for vault.banzaicloud.com/v1alpha1 crd
  • Added the missing config of annotations for vault related Jobs
  • Set env SKIP_CHOWN, SKIP_SETCAP as true and set config disable_mlock as true when Vault is running as non-root

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • [ ] doc-required

    (If you need help on updating docs, create a doc issue)

  • [x] no-need-doc

    (Please explain why)

  • [ ] doc

    (If this PR contains doc changes)

ericsyh avatar Aug 10 '22 12:08 ericsyh

Is the motivation for the security context to support running as non-root or minimal permission mode?

Oh yes. Seems some financial users have strict admission policies for running as non-root or minimal permission mode. I think OpenShift also has similar requirements.

ericsyh avatar Aug 11 '22 01:08 ericsyh

Oh yes. Seems some financial users have strict admission policies for running as non-root or minimal permission mode. I think OpenShift also has similar requirements.

How about we run sn-platform in minimal permission mode by default, or add a flag to do so and generate these security context settings automaticallY/

fantapsody avatar Aug 11 '22 02:08 fantapsody

Please try rebase master for fixed test

tuteng avatar Sep 09 '22 03:09 tuteng

@fantapsody @maxsxu @tuteng PTAL

tuteng avatar Sep 09 '22 03:09 tuteng

Close PR for it is from fork.

ericsyh avatar Oct 10 '22 14:10 ericsyh