charts
charts copied to clipboard
Reorganize auth module
(If this PR fixes a github issue, please add Fixes #<xyz>
.)
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz>
to link to the master issue.)
Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
- [ ] Make sure that the change passes the CI checks.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added integration tests for end-to-end deployment with large payloads (10MB)
- Extended integration test for recovery after broker failure
Documentation
Check the box below.
Need to update docs?
-
[ ]
doc-required
(If you need help on updating docs, create a doc issue)
-
[ ]
no-need-doc
(Please explain why)
-
[ ]
doc
(If this PR contains doc changes)
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
@fantapsody PTAL
@fantapsody Can u take a review again?
I found some jwt auth related configuration in values.yaml and volumeMounts definitions in templates, but no configuration in broker and proxy. How should we handle this, fix or remove? https://github.com/streamnative/charts/blob/93baeacdde7800ac989fbdde32484bc85d97e4cf/charts/sn-platform/values.yaml#L352-L357 https://cs.github.com/streamnative/charts?q=jwt%20path%3A%2F%5Echarts%5C%2Fsn-platform%5C%2F%2F
Move it to next version -> sn-platform-1.6.3
I found some jwt auth related configuration in values.yaml and volumeMounts definitions in templates, but no configuration in broker and proxy. How should we handle this, fix or remove?
https://github.com/streamnative/charts/blob/93baeacdde7800ac989fbdde32484bc85d97e4cf/charts/sn-platform/values.yaml#L352-L357
https://cs.github.com/streamnative/charts?q=jwt%20path%3A%2F%5Echarts%5C%2Fsn-platform%5C%2F%2F
I want to introduce support for jwt in the next pr @ciiiii
@ciiiii @fantapsody PTAL I'll be adding some integration tests to the next pr, as the tests seem to bring in a lot of dependencies like hydra
@fantapsody Pls take a review again.
@fantapsody Can you take a look at this pr again? thanks