charts icon indicating copy to clipboard operation
charts copied to clipboard

[BREAK CHANGE]: remove legacy adopt existing configs

Open ericsyh opened this issue 3 years ago • 5 comments

Signed-off-by: ericsyh [email protected]

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #820

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Remove adopt existing configs.

Modifications

Remove adopt existing configs.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • [ ] doc-required

    (If you need help on updating docs, create a doc issue)

  • [x] no-need-doc

    (Please explain why)

  • [ ] doc

    (If this PR contains doc changes)

ericsyh avatar Jun 08 '22 10:06 ericsyh

@ericsyh:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] avatar Jun 08 '22 10:06 github-actions[bot]

shall we also remove all manifests related to this?

MarvinCai avatar Jun 15 '22 08:06 MarvinCai

shall we also remove all manifests related to this?

@MarvinCai Yeah, sure. I missed it. Will update to remove manifests.

ericsyh avatar Jun 15 '22 11:06 ericsyh

@MarvinCai PTAL https://github.com/streamnative/charts/pull/739/commits/742b55dc9caf7fad9955e0b356ba3461c5b6d33f

ericsyh avatar Jun 16 '22 02:06 ericsyh

@ericsyh We may need to keep this part for a while as we have recently found that some customers are using these options.

fantapsody avatar Jun 30 '22 06:06 fantapsody