charts icon indicating copy to clipboard operation
charts copied to clipboard

Helm chart dependencies do not follow best practices

Open imunhatep opened this issue 5 years ago • 4 comments

Is your feature request related to a problem? Please describe. Charts do not follow common guideline: chart templates bring dependencies into the main chart instead of using Helm dependency

Describe the solution you'd like Move services like prometheus, alert-manager, zookeeper to a chart dependencies, That would simplified helm chart support and usage.

Describe alternatives you've considered Do not see other options, cause the issue is that Chart structure is inconsistent and does not follow best practices

Additional context As a chart reference with a lot of dependencies GitLab helm chart could be taken..

imunhatep avatar Sep 25 '20 13:09 imunhatep

@sijie @wolfstudy Would you please help take a look at this issue?

jiazhai avatar Sep 28 '20 02:09 jiazhai

@Imunhatep Agreed! Are you interested in contributing a pull request to improve it?

sijie avatar Sep 28 '20 05:09 sijie

Sorry but atm no. I've switched to a "smaller" pulsar chart for evaluating..

imunhatep avatar Sep 28 '20 11:09 imunhatep

@Imunhatep Gotcha. Not sure if you have seen this before or not. But you can disable the components you don't need in the values file (https://github.com/streamnative/charts/blob/master/charts/pulsar/values.yaml#L71) and (https://github.com/streamnative/charts/blob/master/charts/pulsar/values.yaml#L98). So you can get a "smaller" pulsar chart for evaluating. Hope that will help you with the evaluation process.

sijie avatar Sep 29 '20 04:09 sijie