aop icon indicating copy to clipboard operation
aop copied to clipboard

Fix - Add permit if receive nack command.

Open casuallc opened this issue 1 year ago • 5 comments

Motivation

Add permit if receive nack command.

The availablePermits will reduce when resend message to consumer.

Modifications

Verifying this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • [x] no-need-doc

casuallc avatar May 08 '23 01:05 casuallc

Please take a look. @gaoran10 @mingyifei

casuallc avatar May 08 '23 01:05 casuallc

Please take a look. @gaoran10 @mingyifei

availablePermits are processed at the time of consumption.

GhostBoyBoy avatar May 09 '23 05:05 GhostBoyBoy

availablePermits are processed at the time of consumption.

CreditManager done not work.

You can try it. When consumer client send nack command, broker will resend message and decrease availablePermits, after 1000 times sended, will blocked. @mingyifei

casuallc avatar May 09 '23 09:05 casuallc

availablePermits are processed at the time of consumption.

CreditManager done not work.

You can try it. When consumer client send nack command, broker will resend message and decrease availablePermits, after 1000 times sended, will blocked. @mingyifei

ok, you can test the multi-bundle implementation, the previous version will be deprecated in the future.

GhostBoyBoy avatar May 11 '23 09:05 GhostBoyBoy

availablePermits are processed at the time of consumption.

CreditManager done not work.

You can try it. When consumer client send nack command, broker will resend message and decrease availablePermits, after 1000 times sended, will blocked. @mingyifei

AmqpMultiBundlesChannel

GhostBoyBoy avatar May 11 '23 09:05 GhostBoyBoy