react-use icon indicating copy to clipboard operation
react-use copied to clipboard

fix: useMeasure typescript error

Open itsjohnong opened this issue 3 years ago • 1 comments

Description

useMeasure hook caused typescript errors because the ref function argument could either be an element or null, but the function only accepted an element.

image

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • [x] Read the Contributing Guide
  • [x] Perform a code self-review
  • [x] Comment the code, particularly in hard-to-understand areas
  • [x] Add documentation
  • [x] Add hook's story at Storybook
  • [x] Cover changes with tests
  • [x] Ensure the test suite passes (yarn test)
  • [x] Provide 100% tests coverage
  • [x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • [x] Make sure types are fine (yarn lint:types).

itsjohnong avatar Sep 15 '22 00:09 itsjohnong

This is a duplicate of #1451 which has been open for a while...

veloek avatar Sep 23 '22 12:09 veloek