react-use icon indicating copy to clipboard operation
react-use copied to clipboard

feat: wrapping useMouseWheel with useRafState

Open slash9494 opened this issue 2 years ago • 0 comments

Description

I found useMouseWheel is to set State directly on the event handler. when I refer to the useScroll which is triggered by the scroll event similar to the wheel event , I thought it would show better performance to set a state through useRafState like useScroll

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • [x] Read the Contributing Guide
  • [x] Perform a code self-review
  • [x] Comment the code, particularly in hard-to-understand areas
  • [x] Add documentation
  • [x] Add hook's story at Storybook
  • [x] Cover changes with tests
  • [x] Ensure the test suite passes (yarn test)
  • [x] Provide 100% tests coverage
  • [x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • [x] Make sure types are fine (yarn lint:types).

slash9494 avatar Aug 14 '22 22:08 slash9494